-
Notifications
You must be signed in to change notification settings - Fork 10.2k
[release-3.5] .github/workflows: Remove grpcproxy.yaml from Github workflows #20236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-3.5] .github/workflows: Remove grpcproxy.yaml from Github workflows #20236
Conversation
Signed-off-by: joshjms <[email protected]>
ivanvc
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Noting that the pull-etcd-grpcproxy-* jobs successfully ran, so we can delete this file. Thanks, Joshua.
|
/cc @jmhbnz |
jmhbnz
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great progress team, the new jobs in https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/etcd-io_etcd/20236/pull-etcd-grpcproxy-e2e-amd64/1938667146372452352 and https://prow.k8s.io/view/gs/kubernetes-ci-logs/pr-logs/pull/etcd-io_etcd/20236/pull-etcd-grpcproxy-integration-amd64/1938667145370013696 look good, so let's remove it!
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ivanvc, jmhbnz, joshjms The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/retitle [release-3.5] .github/workflows: Remove grpcproxy.yaml from Github workflows |
All tests were removed in etcd-io#20099, etcd-io#20236 and etcd-io#20315 as part of the upstream migration to prow kubernetes/test-infra#32754. Since we maintain a fork without tests running in prow, we want to maintain the tests in github actions. Signed-off-by: Ayaz Badouraly <[email protected]>
All tests were removed in etcd-io#20099, etcd-io#20236 and etcd-io#20315 as part of the upstream migration to prow kubernetes/test-infra#32754. Since we maintain a fork without tests running in prow, we want to maintain the tests in github actions. Hence this commit reverts the three pull requests mentioned above with the exception of release.yaml since we do not use the docker images built in this repository. Signed-off-by: Ayaz Badouraly <[email protected]>
All tests were removed in etcd-io#20099, etcd-io#20236 and etcd-io#20315 as part of the upstream migration to prow kubernetes/test-infra#32754. Since we maintain a fork without tests running in prow, we want to maintain the tests in github actions. Hence this commit reverts the three pull requests mentioned above with the exception of release.yaml since we do not use the docker images built in this repository. Signed-off-by: Ayaz Badouraly <[email protected]>
All tests were removed in etcd-io#20099, etcd-io#20236 and etcd-io#20315 as part of the upstream migration to prow kubernetes/test-infra#32754. Since we maintain a fork without tests running in prow, we want to maintain the tests in github actions. Hence this commit reverts the three pull requests mentioned above with the exception of release.yaml since we do not use the docker images built in this repository. Signed-off-by: Ayaz Badouraly <[email protected]>
All tests were removed in etcd-io#20099, etcd-io#20236 and etcd-io#20315 as part of the upstream migration to prow kubernetes/test-infra#32754. Since we maintain a fork without tests running in prow, we want to maintain the tests in github actions. Hence this commit reverts the three pull requests mentioned above with the exception of release.yaml since we do not use the docker images built in this repository. Signed-off-by: Ayaz Badouraly <[email protected]>
Ref: kubernetes/test-infra#32754
/cc @ivanvc @abdurrehman107
Please read https://github.com/etcd-io/etcd/blob/main/CONTRIBUTING.md#contribution-flow.