Skip to content

Conversation

@joshjms
Copy link
Member

@joshjms joshjms commented Jun 27, 2025

Copy link
Member

@ivanvc ivanvc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Noting that the pull-etcd-grpcproxy-* jobs successfully ran, so we can delete this file. Thanks, Joshua.

@ivanvc
Copy link
Member

ivanvc commented Jun 28, 2025

/cc @jmhbnz

@k8s-ci-robot k8s-ci-robot requested a review from jmhbnz June 28, 2025 00:07
Copy link
Member

@jmhbnz jmhbnz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ivanvc, jmhbnz, joshjms

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@jmhbnz jmhbnz merged commit 27d9b9d into etcd-io:release-3.5 Jun 28, 2025
33 checks passed
@ivanvc ivanvc mentioned this pull request Jul 18, 2025
@ivanvc
Copy link
Member

ivanvc commented Jul 18, 2025

/retitle [release-3.5] .github/workflows: Remove grpcproxy.yaml from Github workflows

@k8s-ci-robot k8s-ci-robot changed the title .github/workflows: Remove grpcproxy.yaml from Github workflows [release-3.5] .github/workflows: Remove grpcproxy.yaml from Github workflows Jul 18, 2025
badouralix added a commit to DataDog/etcd that referenced this pull request Nov 24, 2025
All tests were removed in etcd-io#20099,
etcd-io#20236 and
etcd-io#20315 as part of the upstream
migration to prow kubernetes/test-infra#32754.

Since we maintain a fork without tests running in prow, we want to
maintain the tests in github actions.

Signed-off-by: Ayaz Badouraly <[email protected]>
badouralix added a commit to DataDog/etcd that referenced this pull request Nov 24, 2025
All tests were removed in etcd-io#20099,
etcd-io#20236 and
etcd-io#20315 as part of the upstream
migration to prow kubernetes/test-infra#32754.

Since we maintain a fork without tests running in prow, we want to
maintain the tests in github actions. Hence this commit reverts the
three pull requests mentioned above with the exception of release.yaml
since we do not use the docker images built in this repository.

Signed-off-by: Ayaz Badouraly <[email protected]>
badouralix added a commit to DataDog/etcd that referenced this pull request Nov 25, 2025
All tests were removed in etcd-io#20099,
etcd-io#20236 and
etcd-io#20315 as part of the upstream
migration to prow kubernetes/test-infra#32754.

Since we maintain a fork without tests running in prow, we want to
maintain the tests in github actions. Hence this commit reverts the
three pull requests mentioned above with the exception of release.yaml
since we do not use the docker images built in this repository.

Signed-off-by: Ayaz Badouraly <[email protected]>
badouralix added a commit to DataDog/etcd that referenced this pull request Nov 27, 2025
All tests were removed in etcd-io#20099,
etcd-io#20236 and
etcd-io#20315 as part of the upstream
migration to prow kubernetes/test-infra#32754.

Since we maintain a fork without tests running in prow, we want to
maintain the tests in github actions. Hence this commit reverts the
three pull requests mentioned above with the exception of release.yaml
since we do not use the docker images built in this repository.

Signed-off-by: Ayaz Badouraly <[email protected]>
badouralix added a commit to DataDog/etcd that referenced this pull request Nov 27, 2025
All tests were removed in etcd-io#20099,
etcd-io#20236 and
etcd-io#20315 as part of the upstream
migration to prow kubernetes/test-infra#32754.

Since we maintain a fork without tests running in prow, we want to
maintain the tests in github actions. Hence this commit reverts the
three pull requests mentioned above with the exception of release.yaml
since we do not use the docker images built in this repository.

Signed-off-by: Ayaz Badouraly <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

4 participants