Skip to content

Task resolve naming conflict docker#186

Merged
kaseywright merged 4 commits into
mainfrom
task-resolve-naming-conflict-docker
Jun 14, 2026
Merged

Task resolve naming conflict docker#186
kaseywright merged 4 commits into
mainfrom
task-resolve-naming-conflict-docker

Conversation

@kaseywright

@kaseywright kaseywright commented Jun 14, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

Release Notes

  • Chores

    • Updated service configuration with explicit container naming for database, API, and worker services.
  • Improvements

    • Added container liveness verification for API operations to ensure containers are running before command execution.
    • Optimized shell and database command execution with direct container invocation.

kaseywright and others added 4 commits June 14, 2026 10:31
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Resolves passthrough failures when the platform started the stack.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Jun 14, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Explicit container_name values are added to the db, api, and worker services in compose.yaml. Both fapi.ps1 and fapi.sh are updated to use direct docker exec or podman exec calls—with container liveness verification—instead of routing commands through compose exec.

Changes

Direct container exec with liveness checks

Layer / File(s) Summary
Explicit container names in compose.yaml
compose.yaml
Adds container_name: fluent-api-db, fluent-api-api, and fluent-api-worker to the respective services, providing stable names for direct exec commands.
Direct exec helpers with liveness checks
fapi.ps1, fapi.sh
fapi.ps1 adds Test-ContainerRunning (using podman ps or docker ps) and updates Invoke-ExecApi, the shell db branch, and db:psql to use docker exec fluent-api-api/fluent-api-db directly. fapi.sh updates podman_exec_api, compose_exec_api, compose_shell, and compose_db_psql to verify container liveness via ps name-matching before calling $RUNTIME exec or docker exec.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 inconclusive)

Check name Status Explanation Resolution
Title check ❓ Inconclusive The title 'Task resolve naming conflict docker' is vague and lacks specificity about what naming conflict is being resolved or how docker relates to the solution. Revise the title to be more specific about the technical change, such as 'Add explicit container names to Compose services' or 'Fix container naming for Docker exec commands'.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch task-resolve-naming-conflict-docker

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@fapi.sh`:
- Around line 401-407: The docker exec calls in several functions lack
container-running prechecks that are already implemented elsewhere in the
codebase. In fapi.sh file at lines 401-407, add a precheck for DB_CONTAINER when
service equals "db" and for ${CONTAINER_PREFIX}$service in the else branch
before calling docker exec in the compose_shell function. In fapi.sh file at
lines 443-445, add a precheck for DB_CONTAINER before docker exec in the
compose_db_psql function. In fapi.ps1 file at lines 304-305, call
Test-ContainerRunning for both DB_CONTAINER and the target shell container
before docker exec. In fapi.ps1 file at line 352, call Test-ContainerRunning
with "fluent-api-db" before docker exec in the db:psql function. Use the
existing precheck pattern from other exec helpers in these scripts as a
reference for implementation.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 62ec2aa7-95d1-46cc-80aa-893a861d63e6

📥 Commits

Reviewing files that changed from the base of the PR and between 7c7f63d and 74bed04.

📒 Files selected for processing (3)
  • compose.yaml
  • fapi.ps1
  • fapi.sh

Comment thread fapi.sh
@kaseywright kaseywright merged commit 3c471df into main Jun 14, 2026
2 checks passed
@github-actions github-actions Bot deleted the task-resolve-naming-conflict-docker branch June 14, 2026 15:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant