Skip to content

Update received timestamp#7298

Open
lucanovera wants to merge 3 commits intomainfrom
ENG-2433-Received-request-date
Open

Update received timestamp#7298
lucanovera wants to merge 3 commits intomainfrom
ENG-2433-Received-request-date

Conversation

@lucanovera
Copy link
Contributor

@lucanovera lucanovera commented Feb 3, 2026

Ticket ENG-2433

Description Of Changes

Update relative timestamp in Request Manager to show "Received: mm/dd/yy"

Code Changes

  • Updates formatDate option to support date times and just dates

Steps to Confirm

  1. Open request manager
  2. Confirm the items show "Received: mm/dd/yy"
  3. Hovering the Received message shows you the full date, time and timezone strings

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@lucanovera lucanovera marked this pull request as ready for review February 3, 2026 15:38
@lucanovera lucanovera requested a review from a team as a code owner February 3, 2026 15:38
@lucanovera lucanovera requested review from speaker-ender and removed request for a team February 3, 2026 15:38
@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 3, 2026

Greptile Overview

Greptile Summary

Updated the Request Manager to display received dates in short format (MM/dd/yy) instead of relative time (e.g., "2 days ago"). The full timestamp with timezone is still shown on hover via tooltip.

Key Changes:

  • Enhanced formatDate() utility to support optional date-only format via showTime: false parameter
  • Updated ReceivedOn component to use short date format instead of formatDistance()
  • Removed unused imports (formatDistance, sentenceCase)

Issue Found:

  • Filename typo: RevievedOn.tsx should be ReceivedOn.tsx

Confidence Score: 4/5

  • This PR is safe to merge after fixing the filename typo
  • The code changes are straightforward and well-implemented. The only issue is a pre-existing filename typo that should be corrected to avoid confusion
  • RevievedOn.tsx needs to be renamed to ReceivedOn.tsx to fix the spelling error

Important Files Changed

Filename Overview
clients/admin-ui/src/features/common/utils.ts Added optional parameter to formatDate to support date-only format (MM/dd/yy) without time
clients/admin-ui/src/features/privacy-requests/dashboard/list-item/components/RevievedOn.tsx Replaced relative time display with short date format; filename has typo (RevievedOn vs ReceivedOn)

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@@ -1,8 +1,7 @@
import { formatDistance } from "date-fns";
import { Text, Tooltip } from "fidesui";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Filename is misspelled as RevievedOn.tsx when it should be ReceivedOn.tsx

@vercel
Copy link
Contributor

vercel bot commented Feb 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

2 Skipped Deployments
Project Deployment Actions Updated (UTC)
fides-plus-nightly Ignored Ignored Preview Feb 3, 2026 4:21pm
fides-privacy-center Ignored Ignored Feb 3, 2026 4:21pm

Request Review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants