Skip to content

refactor: monitor list items#7301

Merged
speaker-ender merged 1 commit intomainfrom
refactor/monitor-list-items
Feb 6, 2026
Merged

refactor: monitor list items#7301
speaker-ender merged 1 commit intomainfrom
refactor/monitor-list-items

Conversation

@speaker-ender
Copy link
Contributor

@speaker-ender speaker-ender commented Feb 3, 2026

Ticket []

Description Of Changes

Refactors the monitor list items.
Attempting to use OOTB ant patterns as much as possible.
More custom due to requirements

Code Changes

  • Refactoring MonitorResult.tsx to align more closely with the OOTB ListItem component.

Steps to Confirm

  1. Visit the Activity Center
  2. Confirm that list items have no visual regressions
  3. Verify that the list items are more responsive and no longer overlap when content is too wide

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel
Copy link
Contributor

vercel bot commented Feb 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Feb 5, 2026 4:10pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Feb 5, 2026 4:10pm

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 5, 2026

Greptile Overview

Greptile Summary

Refactored MonitorResult component to better align with Ant Design's List.Item component patterns, replacing custom grid layout with OOTB actions and extra props for better responsiveness.

Key changes:

  • Removed custom Row/Col grid layout in favor of Ant's List.Item with actions and extra props
  • Moved "Findings" and "Review" buttons to the actions array for proper Ant Design alignment
  • Moved ConfidenceRow expand/collapse section to the extra prop
  • Refactored stewards avatars and last monitored timestamp as direct children for improved flex layout
  • Updated SCSS module to target Ant's list action elements instead of custom title styles
  • Added responsive flex sizing and visibility classes for better small-screen behavior

Confidence Score: 5/5

  • This PR is safe to merge - it's a well-executed refactoring that simplifies the component structure
  • The refactor properly leverages Ant Design's built-in List.Item patterns, removes unnecessary custom layout code (Row/Col), maintains all existing functionality, and improves responsive behavior through better flex-based layouts. The changes align with the frontend style guide's preference for using Ant Design components over custom implementations.
  • No files require special attention

Important Files Changed

Filename Overview
clients/admin-ui/src/features/data-discovery-and-detection/action-center/MonitorResult.tsx Refactored component to use Ant Design's List.Item pattern with actions and extra props instead of custom grid layout - improves responsive behavior and reduces custom CSS
clients/admin-ui/src/features/data-discovery-and-detection/action-center/MonitorResult.module.scss Replaced custom title styles with layout-focused styles for Ant's list-item-action elements to support the new component structure

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

fix: collapse placement

fix: remove commented out code

refactor: responsive column gaps
Copy link
Contributor

@gilluminate gilluminate left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good! It would be nice to do the same on the https://github.com/ethyca/fides/blob/main/clients/admin-ui/src/features/data-discovery-and-detection/action-center/components/InProgressMonitorTaskItem.tsx stuff in the Activity tab (and maybe even re-organize/rename that components directory)

@speaker-ender speaker-ender added this pull request to the merge queue Feb 6, 2026
Merged via the queue into main with commit 064c4a2 Feb 6, 2026
45 of 46 checks passed
@speaker-ender speaker-ender deleted the refactor/monitor-list-items branch February 6, 2026 01:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants