Skip to content

Add types & rtk slices for privacy assessments#7303

Open
lucanovera wants to merge 4 commits intomainfrom
ENG-2437-privacy-assessments-types-slice
Open

Add types & rtk slices for privacy assessments#7303
lucanovera wants to merge 4 commits intomainfrom
ENG-2437-privacy-assessments-types-slice

Conversation

@lucanovera
Copy link
Contributor

@lucanovera lucanovera commented Feb 3, 2026

Ticket ENG-2437

Description Of Changes

Adds hardcoded types and endpoints to slice files for the privacy assessments features. This allows FE development to happen with MSW mocks while the backend is still being developed.

Note: There is a followup ticket ENG-2507 to replace all hardcoded types with openapi generated ones once they're available.

Code Changes

  • Adds hardcoded types for the feature
  • Adds privacy assessments slice
  • Adds new cache keys for the endpoints

Steps to Confirm

  1. CI passes

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
    • Updates unreleased work already in Changelog, no new entry necessary
  • UX feedback:
    • All UX related changes have been reviewed by a designer
    • No UX review needed
  • Followup issues:
    • Followup issues created
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@lucanovera lucanovera requested a review from a team as a code owner February 3, 2026 19:12
@lucanovera lucanovera requested review from gilluminate and removed request for a team February 3, 2026 19:12
@vercel
Copy link
Contributor

vercel bot commented Feb 3, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
fides-plus-nightly Ready Ready Preview, Comment Feb 3, 2026 7:25pm
1 Skipped Deployment
Project Deployment Actions Updated (UTC)
fides-privacy-center Ignored Ignored Feb 3, 2026 7:25pm

Request Review

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Feb 3, 2026

Greptile Overview

Greptile Summary

This PR adds frontend infrastructure for the privacy assessments feature by introducing hardcoded TypeScript types and RTK Query endpoints. The implementation follows standard patterns used elsewhere in the codebase and sets up the foundation for frontend development with MSW mocks while the backend is being developed.

Key changes:

  • Added comprehensive type definitions for privacy assessments, including discriminated unions for evidence types and well-documented interfaces for requests/responses
  • Implemented 10 RTK Query endpoints covering CRUD operations, questionnaires, evidence tracking, and reminders
  • Added three new cache tags (Privacy Assessment, Privacy Assessment Questionnaire, Privacy Assessment Evidence) with proper invalidation patterns
  • All mutations properly invalidate relevant cache tags to ensure data freshness

Notes:

  • Types are marked as temporary and will be replaced with OpenAPI-generated types in a followup ticket
  • Cache invalidation follows established patterns in the codebase
  • Code is well-structured and ready for integration with MSW mocks

Confidence Score: 5/5

  • This PR is safe to merge with no issues found
  • The code follows established patterns, has proper type safety, correct cache invalidation, and is well-documented. No logical errors, security issues, or violations of custom rules were found.
  • No files require special attention

Important Files Changed

Filename Overview
clients/admin-ui/src/features/privacy-assessments/types.ts Comprehensive type definitions for privacy assessments feature with well-documented interfaces
clients/admin-ui/src/features/privacy-assessments/privacy-assessments.slice.ts RTK Query endpoints for privacy assessments with proper cache invalidation
clients/admin-ui/src/features/common/api.slice.ts Added three new cache tags for privacy assessments feature
clients/admin-ui/src/features/privacy-assessments/index.ts Simple barrel export file for privacy assessments feature

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

4 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants