Open
Conversation
dlech
reviewed
Jan 2, 2026
core/lego_port_class.c
Outdated
| int err; | ||
|
|
||
| if (!port || !port->name || !port->address || !type || !parent) | ||
| if (!port || !port->name || !type || !parent) |
ev3/ev3_ports_out.c
Outdated
| return ret; | ||
|
|
||
| return pwm_apply_state(data->pwm, &state); | ||
| return pwm_apply_might_sleep(data->pwm, &state); |
Member
There was a problem hiding this comment.
I think we want the atomic version here.
…ddress in core/lego_port_class.c
Author
|
@dlech I switched to the atomic version in ev3/ev3_ports_out.c and revert removing port->address in core/lego_port_class.c |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the submodule I used for ev3dev/ev3-kernel#17. It just gets this to compile with the kernel 6.12.y branch. I have not tested this on actual hardware. I would start a new branch rather than merge this into the bookworm branch.