fix(bindings): canonicalize runtime mount replay keys - #2366
Merged
chaliy merged 1 commit intoSep 1, 2026
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | a56f38a | Commit Preview URL | Sep 01 2026, 09:11 AM |
chaliy
force-pushed
the
2026-08-31-propose-fix-for-runtime-mount-vulnerability
branch
from
September 1, 2026 09:10
23e5f2e to
a56f38a
Compare
chaliy
deleted the
2026-08-31-propose-fix-for-runtime-mount-vulnerability
branch
September 1, 2026 09:25
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
reset()from restoring mounts that were explicitly unmounted via an equivalent normalized path by ensuring replay logs use canonical VFS paths.Description
vfs_pathbefore comparing or storing it (crates/bashkit-js/src/lib.rs).crates/bashkit-python/src/lib.rs).reset()for both JS and Python to cover the bug (crates/bashkit-js/__test__/runtime-extension.spec.ts,crates/bashkit-python/tests/test_runtime_extension.py).TM-ISO-025to document the capability-resurrection risk and its mitigation (knowledge/security/threat-model.md).Testing
cargo fmt --all -- --check(passed).cargo check -p bashkit-js -p bashkit-python(passed) andcargo test -p bashkit-js -p bashkit-python --lib(unit/lib tests passed).just check-okf(OKF linting passed).avaand Pythonpytestregressions;pytestcollection failed in this environment because thebashkitPython package was not installed, and the JSavacase could not run here becausenapi/node_modulestooling is not present (napi/pnpm not available). These tests are included in the repo and should pass in CI where build tooling is available.Codex Task