fix(fetch): enforce URL policy on agent probes - #179
Open
chaliy wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
super::validate_url_policy(¤t_url, options)?;at the start of the per-hop loop insidesend_request_following_redirectsso generated probes and redirect hops are checked.test_agent_resource_probes_honor_url_prefix_policythat verifies a/docs-scoped allowlist permits the seed GET but prevents root-level discovery probes from being dispatched.Testing
cargo fmt --all -- --checkand it passed.cargo test -p fetchkit test_agent_resource_probes_honor_url_prefix_policyand it passed.cargo test -p fetchkitfor the crate test suite and tests completed successfully with the new regression included.cargo clippywas attempted in this environment but did not finish within the execution window; please runcargo clippy --workspace --all-targets -- -D warningslocally or in CI as part of pre-merge checks.Codex Task