fix(fetch): retain PDF permits until parsing completes - #180
Open
chaliy wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
pdf_inspectorparse continued, allowing attackers to bypass the intended two-document concurrency cap.Description
LazyLock<Arc<Semaphore>>so permits can be owned and moved into blocking tasks.run_pdf_task(...)which acquires an owned permit and executes the parser insidetokio::task::spawn_blockingwhile keeping the permit alive for the lifetime of the blocking closure.PdfProcessor::processto callrun_pdf_task(...)and preserve existing parsing behavior and results.cancelled_pdf_caller_does_not_release_running_task_permitproving that aborting the async caller does not free the permit while the blocking parse runs, and update knowledge docs to reflect the cancellation-safe concurrency behavior.Testing
cargo fmt --all -- --checkandpython3 scripts/check_okf.py knowledge, both succeeded.cargo test -p fetchkit cancelled_pdf_caller_does_not_release_running_task_permitandcargo test -p fetchkit pdf_processor, both passed.cargo test --workspace, documentation buildRUSTDOCFLAGS='-D warnings' cargo doc --workspace --no-deps, and release buildcargo build --workspace --exclude fetchkit-python --release, all succeeded.cargo clippy --workspace --all-targets -- -D warningsreported unrelated pre-existingclippy::collapsible_matchfindings incrates/fetchkit/src/convert.rsand thus failed; the clippy failures are not introduced by this change.Codex Task