Skip to content

Bump immutable dependency#3972

Open
szdziedzic wants to merge 2 commits into
mainfrom
szdziedzic-codex/fix-dependabot-295-immutable
Open

Bump immutable dependency#3972
szdziedzic wants to merge 2 commits into
mainfrom
szdziedzic-codex/fix-dependabot-295-immutable

Conversation

@szdziedzic

@szdziedzic szdziedzic commented Jul 6, 2026

Copy link
Copy Markdown
Contributor

Why

Resolve https://github.com/expo/eas-cli/security/dependabot/295 by upgrading the transitive immutable dependency to a patched version.

How

Added a top-level Yarn resolution that maps the vulnerable immutable@npm:~3.7.6 descriptor to patched immutable@npm:3.8.3.

This keeps @graphql-tools/relay-operation-optimizer at 7.0.0 and @ardatan/relay-compiler at 12.0.0, avoiding unrelated major GraphQL code-generation toolchain upgrades. The lockfile change is limited to the resolved Immutable version, resolution, and checksum.

Added a changelog entry for the dependency bump.

Test Plan

  • corepack yarn oxfmt package.json CHANGELOG.md yarn.lock
  • corepack yarn install --immutable
  • corepack yarn why immutable -R
  • corepack yarn build
  • corepack yarn typecheck
  • corepack yarn lint (0 errors)
  • corepack yarn fmt:check package.json CHANGELOG.md yarn.lock
  • corepack yarn lint-changelog
  • corepack yarn workspace eas-cli verify-graphql-code
  • EAS CLI Jest suite: 236 suites passed in the sandbox; the six environment-blocked suites were rerun with network and local socket access and all 78 tests passed
  • git diff --check origin/main...HEAD

@codecov

codecov Bot commented Jul 6, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.72%. Comparing base (8204d18) to head (2de4ff5).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3972   +/-   ##
=======================================
  Coverage   59.72%   59.72%           
=======================================
  Files         941      941           
  Lines       41322    41322           
  Branches     8676     8676           
=======================================
  Hits        24674    24674           
  Misses      16554    16554           
  Partials       94       94           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@szdziedzic szdziedzic requested a review from sjchmiela July 6, 2026 21:42
@szdziedzic szdziedzic marked this pull request as ready for review July 6, 2026 21:42
@github-actions

github-actions Bot commented Jul 6, 2026

Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead.

@szdziedzic szdziedzic requested a review from douglowder July 7, 2026 09:11

@sjchmiela sjchmiela left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

By yarn.lock this is a much bigger change than just immutable.

@szdziedzic szdziedzic force-pushed the szdziedzic-codex/fix-dependabot-295-immutable branch from 855104e to 2de4ff5 Compare July 13, 2026 13:32
@github-actions

Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants