Skip to content

[eas-cli] Remove Express from image URL test#4008

Open
sjchmiela wants to merge 1 commit into
mainfrom
stanley/remove-express-image-test
Open

[eas-cli] Remove Express from image URL test#4008
sjchmiela wants to merge 1 commit into
mainfrom
stanley/remove-express-image-test

Conversation

@sjchmiela

Copy link
Copy Markdown
Contributor

Why

The image URL test only needs to serve a single PNG over HTTP. Using Express for that adds an otherwise-unused framework and its dependency tree to EAS CLI test dependencies.

This supersedes #3969. That PR upgrades Express to address the vulnerable transitive path-to-regexp version, but after this change EAS CLI no longer depends on Express, so the affected dependency path is removed instead of upgraded.

What changed

  • replace the Express static server with Node's built-in http server
  • bind to port 0 so the operating system selects an available port
  • remove express and @types/express from packages/eas-cli
  • regenerate the lockfile, removing the associated Express 4 dependency tree

Impact

This only changes test infrastructure. The test continues to exercise the real remote-URL fetch and PNG transparency validation path. There is no EAS CLI runtime behavior change.

Validation

  • yarn workspace eas-cli test src/utils/__tests__/image-test.ts --runInBand
  • yarn workspace eas-cli typecheck
  • formatting check
  • git diff --check

@sjchmiela sjchmiela changed the title Remove Express from image URL test [eas-cli] Remove Express from image URL test Jul 13, 2026
@sjchmiela sjchmiela added the no changelog PR that doesn't require a changelog entry label Jul 13, 2026
@sjchmiela sjchmiela marked this pull request as ready for review July 13, 2026 10:16
@github-actions

Copy link
Copy Markdown

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

@github-actions

Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead.

@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.67%. Comparing base (4b1f785) to head (bf275da).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4008   +/-   ##
=======================================
  Coverage   59.67%   59.67%           
=======================================
  Files         941      941           
  Lines       41319    41319           
  Branches     8675     8675           
=======================================
  Hits        24654    24654           
  Misses      16571    16571           
  Partials       94       94           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjchmiela sjchmiela requested a review from szdziedzic July 13, 2026 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no changelog PR that doesn't require a changelog entry

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants