[eas-cli] Remove Express from image URL test#4008
Open
sjchmiela wants to merge 1 commit into
Open
Conversation
|
⏩ The changelog entry check has been skipped since the "no changelog" label is present. |
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4008 +/- ##
=======================================
Coverage 59.67% 59.67%
=======================================
Files 941 941
Lines 41319 41319
Branches 8675 8675
=======================================
Hits 24654 24654
Misses 16571 16571
Partials 94 94 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
szdziedzic
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The image URL test only needs to serve a single PNG over HTTP. Using Express for that adds an otherwise-unused framework and its dependency tree to EAS CLI test dependencies.
This supersedes #3969. That PR upgrades Express to address the vulnerable transitive
path-to-regexpversion, but after this change EAS CLI no longer depends on Express, so the affected dependency path is removed instead of upgraded.What changed
httpserver0so the operating system selects an available portexpressand@types/expressfrompackages/eas-cliImpact
This only changes test infrastructure. The test continues to exercise the real remote-URL fetch and PNG transparency validation path. There is no EAS CLI runtime behavior change.
Validation
yarn workspace eas-cli test src/utils/__tests__/image-test.ts --runInBandyarn workspace eas-cli typecheckgit diff --check