Upgrade xmldom through parent dependencies#4010
Open
sjchmiela wants to merge 2 commits into
Open
Conversation
|
✅ Thank you for adding the changelog entry! |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4010 +/- ##
=======================================
Coverage 59.67% 59.67%
=======================================
Files 941 941
Lines 41319 41319
Branches 8675 8675
=======================================
Hits 24654 24654
Misses 16571 16571
Partials 94 94 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Subscribed to pull request
Generated by CodeMention Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead. |
szdziedzic
approved these changes
Jul 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Supersedes #3967.
Dependabot alert 372 requires
@xmldom/xmldom0.8.13. The original PR used a root resolution to force 0.8.13 through parents that declared the incompatible~0.7.7range. This replacement upgrades those parent dependencies instead, so xmldom can be updated without overriding any package's declared contract.How
@expo/plistdependency from 0.2.0 to 0.3.5.@expo/plistrange from^0.2.0to^0.3.5.@expo/prebuild-configfrom 8.0.17 to 9.0.12, moving its config-plugin chain to a version that uses the newer plist package.@xmldom/xmldom0.8.13.After these changes, every installed plist consumer declares
@xmldom/xmldom ^0.8.8, andyarn why @xmldom/xmldomreports a single natural 0.8.13 installation. No root resolution is added.The relevant
getPrebuildConfigAsynciOS path used by EAS CLI for entitlement inspection is unchanged across the prebuild-config upgrade; the direct implementation change is confined to passingprojectRootto the Android plugin path.Test Plan
yarn installyarn why @xmldom/xmldomyarn build— all 13 projects passed with xmldom 0.8.13 installedUpdatesModuleiOS suite — 2 tests passedyarn fmtyarn fmt:checkyarn lint— 0 errors; 13 pre-existing warnings also present onmain