Skip to content

Upgrade xmldom through parent dependencies#4010

Open
sjchmiela wants to merge 2 commits into
mainfrom
stanley/update-xmldom-with-parent-dependencies
Open

Upgrade xmldom through parent dependencies#4010
sjchmiela wants to merge 2 commits into
mainfrom
stanley/update-xmldom-with-parent-dependencies

Conversation

@sjchmiela

Copy link
Copy Markdown
Contributor

Why

Supersedes #3967.

Dependabot alert 372 requires @xmldom/xmldom 0.8.13. The original PR used a root resolution to force 0.8.13 through parents that declared the incompatible ~0.7.7 range. This replacement upgrades those parent dependencies instead, so xmldom can be updated without overriding any package's declared contract.

How

  • Upgrade EAS CLI's direct @expo/plist dependency from 0.2.0 to 0.3.5.
  • Upgrade build-tools' @expo/plist range from ^0.2.0 to ^0.3.5.
  • Upgrade EAS CLI's @expo/prebuild-config from 8.0.17 to 9.0.12, moving its config-plugin chain to a version that uses the newer plist package.
  • Upgrade the transitive lockfile entry to @xmldom/xmldom 0.8.13.

After these changes, every installed plist consumer declares @xmldom/xmldom ^0.8.8, and yarn why @xmldom/xmldom reports a single natural 0.8.13 installation. No root resolution is added.

The relevant getPrebuildConfigAsync iOS path used by EAS CLI for entitlement inspection is unchanged across the prebuild-config upgrade; the direct implementation change is confined to passing projectRoot to the Android plugin path.

Test Plan

  • yarn install
  • yarn why @xmldom/xmldom
  • yarn build — all 13 projects passed with xmldom 0.8.13 installed
  • Four build-tools plist/configuration suites — 19 tests and 14 snapshots passed
  • EAS CLI UpdatesModule iOS suite — 2 tests passed
  • yarn fmt
  • yarn fmt:check
  • yarn lint — 0 errors; 13 pre-existing warnings also present on main

@github-actions

Copy link
Copy Markdown

✅ Thank you for adding the changelog entry!

@codecov

codecov Bot commented Jul 13, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 59.67%. Comparing base (c944298) to head (466d91e).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4010   +/-   ##
=======================================
  Coverage   59.67%   59.67%           
=======================================
  Files         941      941           
  Lines       41319    41319           
  Branches     8675     8675           
=======================================
  Hits        24654    24654           
  Misses      16571    16571           
  Partials       94       94           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@sjchmiela sjchmiela marked this pull request as ready for review July 13, 2026 13:02
@sjchmiela sjchmiela requested a review from szdziedzic July 13, 2026 13:02
@github-actions

Copy link
Copy Markdown

Subscribed to pull request

File Patterns Mentions
**/* @douglowder

Generated by CodeMention

Warning: The preamble and epilogue options in commentConfiguration are deprecated. Use template instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants