Conversation
Signed-off-by: Ulises Gascon <ulisesgascongonzalez@gmail.com>
blakeembrey
approved these changes
Oct 22, 2024
bjohansebas
approved these changes
Oct 23, 2024
Member
bjohansebas
left a comment
bjohansebas
left a comment
There was a problem hiding this comment.
Maybe it could also be added as a PR template.
|
I would stick to the original template Just because we can easily leverage the ADR generation using one of the available cli tools available on npm |
Member
Author
|
As agreed on the last TC meeting I am merging the PR. @bjohansebas can you create the PR template? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #285
Note: this template was used in #290 and #289