Open
Conversation
bjohansebas
reviewed
Nov 8, 2025
| - Which Node.js versions must be tested by default? (e.g., 22 + 24 vs 18 + 20 + 22 + LTS) | ||
| - Should push validation run on all branches or exclude `main`? | ||
| - Naming convention for workflows (`ci.yml`, `test.yml`, `validate.yml`)? | ||
| - Should `npm audit` or dependency checks be mandatory or optional? |
Member
There was a problem hiding this comment.
It definitely should be optional. All our dependencies are our own, and adding npm audit will only create noise in the workflow
Contributor
There was a problem hiding this comment.
It’s not noise if it alerts about unaddressed CVEs tho
sheplu
force-pushed
the
rfc-define-core-workflows
branch
from
46eaef6 to
7c0d0cb
Compare
Member
Author
|
@expressjs/express-tc to be reviewed, definitely not priority 1 but this can spark a few discussion about the minimal requirement for all repos |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
RFC to standardize the minimal set of workflows expected on all repositories