Fix: Timing-related issue with clean-shutdown tests.#233
Merged
griffinmilsap merged 1 commit intodevfrom Mar 17, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a timing race in shutdown test orchestration that could cause inconsistent return codes in
test_shutdown_exception_on_cancel.Problem
tests/shutdown_runner.pyemittedREADYas soon asrunner.runningbecameTrue.In some runs, that happened before the target task actually entered its execution loop.
As a result:
0instead of a SIGINT code (130/-SIGINT)Changes
Updated
tests/shutdown_runner.pyto synchronize readiness with actual task start:STARTEDevent.STARTEDat entry of each task used by shutdown tests:BlockingDiskIO.blocked_readBlockingSocket.blocked_recvExplodeOnCancel.explodeStubbornTask.ignore_cancelrunner.runningto:
runner.running and STARTED.is_set()Why this fix
This ensures signal injection only starts after the target task is truly active, making shutdown behavior tests deterministic and aligned with the scenario they are intended to validate.
Testing
pytest tests/test_clean_shutdown.py::test_shutdown_exception_on_cancel -qpytest tests/test_clean_shutdown.py -qBoth pass consistently with this change.