[Beam] Fix DateTime tests to use InvariantCulture for locale independence#4346
Merged
[Beam] Fix DateTime tests to use InvariantCulture for locale independence#4346
Conversation
…ence DateTime formatting tests were failing on systems with non-US/UK locales because they depended on system locale settings. Added explicit CultureInfo.InvariantCulture to affected tests when running on .NET. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CultureInfo.InvariantCulturewrapped in#if !FABLE_COMPILERto ensure consistent behavior across all system locales when running on .NETThe tests were expecting UK-style date/time formats (24-hour, day before month) but would fail on systems with other locale settings (e.g., US or Norwegian locales).
Test plan
./build.sh test beam🤖 Generated with Claude Code