docs(cli): remove broken "MoreMenu — In Toolbar" example block#3173
Merged
cixzhang merged 1 commit intoJun 27, 2026
Merged
Conversation
Closes facebook#2870. The 'MoreMenu — In Toolbar' example rendered incorrectly and duplicated coverage already provided by the other MoreMenu examples. Remove the template block and its doc entry; the docsite example registry regenerates cleanly without it.
durvesh1992
requested review from
cixzhang,
ejhammond,
imdreamrunner,
josephfarina,
marie-lucas,
nynexman4464 and
thedjpetersen
as code owners
|
Someone is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
meta-cla
Bot
added
the
CLA Signed
cixzhang
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2870.
The "MoreMenu — In Toolbar" example rendered incorrectly and duplicated coverage already provided by the other MoreMenu examples (Default, With Dividers, With Sections, Showcase). Removed the template block and its doc entry.
Deleted:
packages/cli/templates/blocks/components/MoreMenu/MoreMenuInToolbar.tsxpackages/cli/templates/blocks/components/MoreMenu/MoreMenuInToolbar.doc.mjsTesting
node apps/docsite/scripts/generate-data.mjs) — example registry rebuilds cleanly without the block (no errors; block count drops accordingly).check:changesetsandcheck:syncpass.Notes
@astryxdesign/clishipstemplates/, so a patch changeset is included.InToolbarinapps/storybook/stories/MoreMenu.stories.tsx. I left it untouched since this issue is scoped to the docsite example, and removing it would orphan theButtonimport (it's that story's only consumer). Happy to remove it too in a follow-up if you'd like.