docs(core): document Heading's justify prop#3176
Merged
Merged
Conversation
Closes facebook#2847. Heading supports a `justify` prop (TextJustify: 'start' | 'center' | 'end') but it was missing from the docsite properties tab because the prop was absent from Heading's doc props array. Add it to the English, Chinese, and dense doc exports. Audited the rest of the list against HeadingProps — `justify` was the only omission.
durvesh1992
requested review from
cixzhang,
ejhammond,
imdreamrunner,
josephfarina,
marie-lucas,
nynexman4464 and
thedjpetersen
as code owners
|
Someone is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
meta-cla
Bot
added
the
CLA Signed
cixzhang
approved these changes
Jun 26, 2026
Contributor
|
Thanks for updating this! |
This was referenced Jun 27, 2026
cixzhang
pushed a commit
to durvesh1992/astryx
that referenced
this pull request
Jun 29, 2026
Text supports a justify prop (TextJustify: 'start' | 'center' | 'end') but it was missing from the docsite properties tab — the same omission fixed for its sibling Heading in facebook#3176. Add it to Text's doc props. Found by scanning component interfaces vs their .doc.mjs prop lists.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #2847.
Headingsupports ajustifyprop (TextJustify:'start' | 'center' | 'end', default'start') for text alignment, but it was missing from the docsite properties tab. The properties tab is driven by thepropsarray inpackages/core/src/Text/Heading.doc.mjs, andjustifysimply wasn't listed.Added
justifyto all three doc exports (docs,docsZh,docsDense), positioned aftertextWrapto match the interface order.Testing
HeadingPropsinterface against the doc's prop list —justifywas the only omission.generate-data.mjs—justifynow appears in the generated Heading component registry.Changeset
Included (
@astryxdesign/corepatch, docs) since.doc.mjsships incore/src.