fix(docsite): seed OverflowList properties-tab preview with items#3183
fix(docsite): seed OverflowList properties-tab preview with items#3183durvesh1992 wants to merge 1 commit into
Conversation
Closes facebook#2872. OverflowList's children prop is required, so the properties-tab preview rendered an empty list. Add playground.defaults.children (a few Button items) so the interactive preview shows a real, meaningful list. Adds a preview-state test asserting the children resolve and no required props are reported missing.
|
Someone is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Nice! There's a merge conflict. |
cixzhang
left a comment
There was a problem hiding this comment.
I authorized the preview so we can take a look. We could maybe provide some width to the overflow list's container, and maybe add a default for the overflowRenderer in the playground as well since it only shows one item by default right now. Thanks for working on this!
|
Thanks for authorizing the preview! Two things, one with a constraint:
Given that, I think the cleaner way to show overflow properly (constrained width + a real
Happy to do either/both. (Heads-up: I can't launch a browser in my environment, so I'd lean on your authorized preview to confirm the visual once I push.) |
Summary
Closes #2872.
OverflowList'schildrenprop is required, so the docsite properties-tab preview rendered an empty list ("can't render standalone"). Addplayground.defaults.children(a few Button items) so the interactive preview shows a real, meaningful list.packages/core/src/OverflowList/OverflowList.doc.mjs— addedplayground.defaults.children.Testing
buildInitialStateresolves the seeded children into 3 elements andgetMissingRequiredPropsis empty.component-preview-state.test.ts— 9/9 pass.Changeset
Included (
@astryxdesign/corepatch, docs).