docs(cli): make Typeahead/Tokenizer/FileInput showcases interactive#3201
Open
durvesh1992 wants to merge 1 commit into
Open
docs(cli): make Typeahead/Tokenizer/FileInput showcases interactive#3201durvesh1992 wants to merge 1 commit into
durvesh1992 wants to merge 1 commit into
Conversation
Completes the frozen-showcase fixes (after facebook#3199, facebook#3200). These rendered controlled components with a static value + no-op onChange. Wire local state: Typeahead useState<SearchableItem|null>, Tokenizer useState<SearchableItem[]>, FileInput useState<File|File[]|null>. Typeahead also gains 'use client'.
durvesh1992
requested review from
cixzhang,
ejhammond,
imdreamrunner,
josephfarina,
marie-lucas,
nynexman4464 and
thedjpetersen
as code owners
|
Someone is attempting to deploy a commit to the Meta Open Source Team on Vercel. A member of the Team first needs to authorize it. |
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes the frozen-showcase fixes (after #3199 and #3200). These three showcase blocks rendered controlled components with a static
valueand a no-oponChange, so their docsite previews were frozen. Wired local state:useState<SearchableItem | null>(null)(+'use client')useState<SearchableItem[]>([...])(onChange's(items, change)signature accepts thesetStatesetter)useState<File | File[] | null>(null)Testing
value/onChangesignatures (Typeahead(item: T | null) => void, Tokenizer(items: T[], change) => void, FileInput(files: File | File[] | null) => void).Changeset
Included (
@astryxdesign/clipatch).