prelude/cxx: Provide TemplatePlaceholderInfo from prebuilt_cxx_library. - #1464
prelude/cxx: Provide TemplatePlaceholderInfo from prebuilt_cxx_library.#1464jeandudey wants to merge 3 commits into
Conversation
cxx_library builds the $(cxxppflags), $(cppflags) and $(ldflags-*) macros inline, this can be usefult for other rules such as haskell_library and prebuilt_cxx_library. This moves the code as-is into cxx/template_placeholders.bzl so other rules can use it. The preprocessor info is optional, as haskell_library exports none.
The $(cxxppflags :some_prebuilt_cxx) does not resolve in a cxx_genrule, because no TemplatePlaceholderInfo is returned by prebuilt_cxx_library. This is helpful for example for running bindgen on a genrule against the headers of a prebuilt_cxx_library.
|
Hi @jeandudey! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
meta-cla
Bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
1 participant
This deduplicates the
TemplatePlaceholderInfocode betweencxx_libraryandhaskell_libraryinto a helper, and additionally adds theTemplatePlaceholderInfotoprebuilt_cxx_library.