[Nexthop] Use real timestamps from retrieved port stats for port line rate calculation - #1505
Open
vvasavada-nexthop wants to merge 1 commit into
Open
Conversation
…rate calculation Signed-off-by: vvasavada-nexthop <vvasavada@nexthop.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Port stats are sampled asynchronously by the stats thread, so the real interval between two samples can differ from the requested sleep duration. Use the actual timestamp delta when available.
This is a change similar to the one found in 21c4e2a which did the same fix for AgentPortBandWidthTests.cpp and will help reduce the flakiness in the tests that depend on this function.
Test Plan
Ran
AgentOlympicQosSchedulerTest.VerifyWRRAndNCwhich depends on this function and it still passes with the change.