[Meta] Fix fake sai issues. - #1509
Closed
AarjunC wants to merge 1 commit into
Closed
Conversation
Summary:
D113583401 split the SAI platform sources by vendor, so the sim's MONTBLANC fruid
no longer resolves ("Unsupported SAI platform type PLATFORM_MONTBLANC"). Pointing
the sim at FAKE_SAI swaps Tomahawk5Asic for FakeAsic, which exposed two fake-only
crashes in the hw agent stats path (the second was masked by the first):
- SIGFPE: FakeAsic::getNumMemoryBuffers() returned 0 and
SaiBufferManager::getIngressPoolDivisor() divides by it on every stats tick.
Now 1.
- SIGSEGV at 0x0: populate_router_interface_api() left the get/clear stats
pointers null while SaiRouterInterfaceManager::updateStats() calls getStats()
unconditionally. Added zero-filling stubs matching FakeSaiTunnel.
Also: fruid.json MONTBLANC -> FAKE_SAI; mono.conf uses controlling ports 0,4,8,12
@ 100G profile 28, cpu queue id 9 -> 7 with matching cpuVoqs, asicType 13 -> 1;
FakeAsic denies TEMPERATURE_MONITORING; FakeTestPlatformMapping gets
PROFILE_DEFAULT; each agent unit logs to its own file so concurrent crash traces
stop interleaving.
All fbcode changes are fake-only and do not affect real h/w.
Differential Revision: D115647993
Contributor
|
@AarjunC has exported this pull request. If you are a Meta employee, you can view the originating Diff in D115647993. |
Contributor
|
This pull request has been merged in 1e8e309. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
D113583401 split the SAI platform sources by vendor, so the sim's MONTBLANC fruid
no longer resolves ("Unsupported SAI platform type PLATFORM_MONTBLANC"). Pointing
the sim at FAKE_SAI swaps Tomahawk5Asic for FakeAsic, which exposed two fake-only
crashes in the hw agent stats path (the second was masked by the first):
SaiBufferManager::getIngressPoolDivisor() divides by it on every stats tick.
Now 1.
pointers null while SaiRouterInterfaceManager::updateStats() calls getStats()
unconditionally. Added zero-filling stubs matching FakeSaiTunnel.
Also: fruid.json MONTBLANC -> FAKE_SAI; mono.conf uses controlling ports 0,4,8,12
@ 100G profile 28, cpu queue id 9 -> 7 with matching cpuVoqs, asicType 13 -> 1;
FakeAsic denies TEMPERATURE_MONITORING; FakeTestPlatformMapping gets
PROFILE_DEFAULT; each agent unit logs to its own file so concurrent crash traces
stop interleaving.
Differential Revision: D115647993