[Cisco] Rate limit QSFP port state machine update log - #1512
Open
asrouji wants to merge 1 commit into
Open
Conversation
asrouji
marked this pull request as ready for review
August 12, 2026 23:30
asrouji
force-pushed
the
asrouji/rate-limit-qsfp-port-state-machine-log
branch
from
August 12, 2026 23:50
7cf620e to
5530691
Compare
Demote and rate limit the periodic all-port state machine update message while preserving its state-machine log prefix.
asrouji
force-pushed
the
asrouji/rate-limit-qsfp-port-state-machine-log
branch
from
August 13, 2026 18:11
5530691 to
90a3fe4
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
PortManager::handlePendingUpdates()logs that it is trying to update every port state machine on each periodic update pass, even when there is no noteworthy state change. On a 64-port system this single message accounted for more than 10,000 lines in a 100,000-lineqsfp_servicelog sample.Log the periodic message at
DBG2at most once every 30 seconds. The existing[SM]prefix is preserved.Test Plan
fboss/qsfp_service/PortManager.cpp; clang-format and all applicable checks passed.qsfp_servicewith this change and hot-swapped the binary on a live Cisco C8501 (MORGAN800CC). The service remained active and the standard FBOSS service and routing health checks remained clean.qsfp_servicelog samples before and after the change. Occurrences of this message fell from 10,797 to 16.