[Nexthop] Define TAJO_SDK for cmake builds with SAI_TAJO_IMPL - #1514
Draft
raghavv-nexthop wants to merge 1 commit into
Draft
[Nexthop] Define TAJO_SDK for cmake builds with SAI_TAJO_IMPL#1514raghavv-nexthop wants to merge 1 commit into
raghavv-nexthop wants to merge 1 commit into
Conversation
Signed-off-by: raghavv-nexthop <raghavv@nexthop.ai>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-submission checklist
pip install -r requirements-dev.txt && pre-commit installpre-commit runSummary
Issue
The
AgentAclTableGroupTrafficTest.VerifyDscpMarkingAndTtlAclTableagent_hw test would fail this equality check:Cause
The OSS cmake build never defined the
TAJO_SDKmacro, which fbcode supplies from its tp2 SAI config. FBOSS uses that macro to gate Tajo-specific SAI attribute mappings, so cmake-built binaries were compiling the generic (non-Tajo) code paths on Tajo hardware.The visible symptom was
AgentAclTableGroupTrafficTest.VerifyDscpMarkingAndTtlAclTablefailing onwedge800cact:SaiAclTableManageradvertisedSAI_ACL_TABLE_ATTR_FIELD_IPV6_NEXT_HEADERin the ACL table's key profile while the entries only setIP_PROTOCOL_NUMBER. That mismatch meant the marking entries never matched: traffic flowed, but ACL hit counters read 0.Solution
This adds
add_definitions (-DTAJO_SDK)to theSAI_TAJO_IMPLblock, mirroring the existingCHENAB_SAI_SDKhandling in the same file.Test Plan
After incorporating this change, I ran the test on a Wedge800cact unit using this command:
which produced these results: