Fix quote block indentation bug by accumulating indent values - #82
Open
jwatzman wants to merge 1 commit into
Open
Fix quote block indentation bug by accumulating indent values#82jwatzman wants to merge 1 commit into
jwatzman wants to merge 1 commit into
Conversation
Instead of appending a separate indent attribute for each block-level ancestor, accumulate all indent values into a single totalIndent and emit one .indent_internal attribute. This prevents child node indent values (e.g. ParagraphNode's 0) from overwriting parent indent values (e.g. QuoteNode's 1) during attribute merging. Adds regression test testParagraphInsideQuoteRetainsIndent verifying that text inside a QuoteNode receives the correct headIndent and firstLineHeadIndent from the quote's indent level. This brings the quote node behavior of lexical-ios to match the behavior of lexical web.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of appending a separate indent attribute for each block-level ancestor, accumulate all indent values into a single totalIndent and emit one .indent_internal attribute. This prevents child node indent values (e.g. ParagraphNode's 0) from overwriting parent indent values (e.g. QuoteNode's 1) during attribute merging.
Adds regression test testParagraphInsideQuoteRetainsIndent verifying that text inside a QuoteNode receives the correct headIndent and firstLineHeadIndent from the quote's indent level.
This brings the quote node behavior of lexical-ios to match the behavior of lexical web.