Register CodeNode and LineBreakNode by default; decode CodeNode language leniently - #83
Open
jwatzman wants to merge 1 commit into
Open
Register CodeNode and LineBreakNode by default; decode CodeNode language leniently#83jwatzman wants to merge 1 commit into
jwatzman wants to merge 1 commit into
Conversation
…age leniently Two fixes that allow editor states containing code blocks to round-trip through EditorState.fromJSON: - CodeNode and LineBreakNode are built-in node types with public NodeTypes and full rendering support, but neither was present in Editor's default registeredNodes map. As a result, deserializing any editor state that contains a code block (or a bare line break) could not reconstruct those nodes. Register them alongside the other built-ins (root, text, element, heading, paragraph, quote). - CodeNode's Decodable init required a "language" key. Editor states produced by other Lexical implementations (e.g. lexical-web) omit "language" when no language is set, so decoding threw keyNotFound. Use decodeIfPresent with an empty-string default so a missing language is tolerated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two fixes that allow editor states containing code blocks to round-trip through EditorState.fromJSON: