Fix usort_file write condition to check error instead of output truth…#360
Open
thatch wants to merge 1 commit into
Open
Fix usort_file write condition to check error instead of output truth…#360thatch wants to merge 1 commit into
thatch wants to merge 1 commit into
Conversation
…iness `if result.output and write:` treated b"" as "don't write", which would silently skip the write for a legitimately empty sorted file, or mask any future bug that produces empty output for non-empty input. Check `result.error is None` instead, which is the correct signal that sorting succeeded. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…iness
if result.output and write:treated b"" as "don't write", which would silently skip the write for a legitimately empty sorted file, or mask any future bug that produces empty output for non-empty input. Checkresult.error is Noneinstead, which is the correct signal that sorting succeeded.