fix windows build setuptools error #1316
Closed
+21
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: The upgrade of setuptools in D79195099 broke pywatchman build, Github windows CI erroring with `AttributeError: module 'setuptools.dist' has no attribute 'check_test_suite'` https://github.com/facebook/watchman/actions/runs/19440507973/job/55622405533#step:131:1188 . It was only affecting windows as only windows CI is building dependencies form source, the others use system dependencies. Fix by pinning watchman to the previous setuptools version Fix to help iterate locally: * fix the cargo.py remove behaviour to use rmtree_more. This fixes repeat local builds while debugging. After the first build was getting `PermissionError: [WinError 5] Access is denied: 'Z:\build\fbthrift\source\.git\objects\pack\pack-250eb41d409d8c0f512fdb239d0225fa35d50c3d.idx'` Differential Revision: D87655865
bigfootjon
approved these changes
Nov 24, 2025
Member
bigfootjon
left a comment
bigfootjon
left a comment
There was a problem hiding this comment.
Review automatically exported from Phabricator review in Meta.
meta-codesync bot
pushed a commit
to facebook/fboss
that referenced
this pull request
Nov 24, 2025
Summary: X-link: facebook/watchman#1316 The upgrade of setuptools in D79195099 broke pywatchman build, Github windows CI erroring with `AttributeError: module 'setuptools.dist' has no attribute 'check_test_suite'` https://github.com/facebook/watchman/actions/runs/19440507973/job/55622405533#step:131:1188 . It was only affecting windows as only windows CI is building dependencies form source, the others use system dependencies. Fix by pinning watchman to the previous setuptools version Fix to help iterate locally: * fix the cargo.py remove behaviour to use rmtree_more. This fixes repeat local builds while debugging. After the first build was getting `PermissionError: [WinError 5] Access is denied: 'Z:\build\fbthrift\source\.git\objects\pack\pack-250eb41d409d8c0f512fdb239d0225fa35d50c3d.idx'` Reviewed By: bigfootjon Differential Revision: D87655865 fbshipit-source-id: 8948b0ffe38f304fa96051bf6ac3a0455ef1a16e
|
This pull request has been merged in d4bfc4d. |
meta-codesync bot
pushed a commit
to facebook/folly
that referenced
this pull request
Nov 24, 2025
Summary: X-link: facebook/watchman#1316 The upgrade of setuptools in D79195099 broke pywatchman build, Github windows CI erroring with `AttributeError: module 'setuptools.dist' has no attribute 'check_test_suite'` https://github.com/facebook/watchman/actions/runs/19440507973/job/55622405533#step:131:1188 . It was only affecting windows as only windows CI is building dependencies form source, the others use system dependencies. Fix by pinning watchman to the previous setuptools version Fix to help iterate locally: * fix the cargo.py remove behaviour to use rmtree_more. This fixes repeat local builds while debugging. After the first build was getting `PermissionError: [WinError 5] Access is denied: 'Z:\build\fbthrift\source\.git\objects\pack\pack-250eb41d409d8c0f512fdb239d0225fa35d50c3d.idx'` Reviewed By: bigfootjon Differential Revision: D87655865 fbshipit-source-id: 8948b0ffe38f304fa96051bf6ac3a0455ef1a16e
meta-codesync bot
pushed a commit
to facebook/mvfst
that referenced
this pull request
Nov 24, 2025
Summary: X-link: facebook/watchman#1316 The upgrade of setuptools in D79195099 broke pywatchman build, Github windows CI erroring with `AttributeError: module 'setuptools.dist' has no attribute 'check_test_suite'` https://github.com/facebook/watchman/actions/runs/19440507973/job/55622405533#step:131:1188 . It was only affecting windows as only windows CI is building dependencies form source, the others use system dependencies. Fix by pinning watchman to the previous setuptools version Fix to help iterate locally: * fix the cargo.py remove behaviour to use rmtree_more. This fixes repeat local builds while debugging. After the first build was getting `PermissionError: [WinError 5] Access is denied: 'Z:\build\fbthrift\source\.git\objects\pack\pack-250eb41d409d8c0f512fdb239d0225fa35d50c3d.idx'` Reviewed By: bigfootjon Differential Revision: D87655865 fbshipit-source-id: 8948b0ffe38f304fa96051bf6ac3a0455ef1a16e
meta-codesync bot
pushed a commit
to facebookexperimental/moxygen
that referenced
this pull request
Nov 24, 2025
Summary: X-link: facebook/watchman#1316 The upgrade of setuptools in D79195099 broke pywatchman build, Github windows CI erroring with `AttributeError: module 'setuptools.dist' has no attribute 'check_test_suite'` https://github.com/facebook/watchman/actions/runs/19440507973/job/55622405533#step:131:1188 . It was only affecting windows as only windows CI is building dependencies form source, the others use system dependencies. Fix by pinning watchman to the previous setuptools version Fix to help iterate locally: * fix the cargo.py remove behaviour to use rmtree_more. This fixes repeat local builds while debugging. After the first build was getting `PermissionError: [WinError 5] Access is denied: 'Z:\build\fbthrift\source\.git\objects\pack\pack-250eb41d409d8c0f512fdb239d0225fa35d50c3d.idx'` Reviewed By: bigfootjon Differential Revision: D87655865 fbshipit-source-id: 8948b0ffe38f304fa96051bf6ac3a0455ef1a16e
meta-codesync bot
pushed a commit
to facebook/CacheLib
that referenced
this pull request
Nov 24, 2025
Summary: X-link: facebook/watchman#1316 The upgrade of setuptools in D79195099 broke pywatchman build, Github windows CI erroring with `AttributeError: module 'setuptools.dist' has no attribute 'check_test_suite'` https://github.com/facebook/watchman/actions/runs/19440507973/job/55622405533#step:131:1188 . It was only affecting windows as only windows CI is building dependencies form source, the others use system dependencies. Fix by pinning watchman to the previous setuptools version Fix to help iterate locally: * fix the cargo.py remove behaviour to use rmtree_more. This fixes repeat local builds while debugging. After the first build was getting `PermissionError: [WinError 5] Access is denied: 'Z:\build\fbthrift\source\.git\objects\pack\pack-250eb41d409d8c0f512fdb239d0225fa35d50c3d.idx'` Reviewed By: bigfootjon Differential Revision: D87655865 fbshipit-source-id: 8948b0ffe38f304fa96051bf6ac3a0455ef1a16e
meta-codesync bot
pushed a commit
to facebook/fb303
that referenced
this pull request
Nov 24, 2025
Summary: X-link: facebook/watchman#1316 The upgrade of setuptools in D79195099 broke pywatchman build, Github windows CI erroring with `AttributeError: module 'setuptools.dist' has no attribute 'check_test_suite'` https://github.com/facebook/watchman/actions/runs/19440507973/job/55622405533#step:131:1188 . It was only affecting windows as only windows CI is building dependencies form source, the others use system dependencies. Fix by pinning watchman to the previous setuptools version Fix to help iterate locally: * fix the cargo.py remove behaviour to use rmtree_more. This fixes repeat local builds while debugging. After the first build was getting `PermissionError: [WinError 5] Access is denied: 'Z:\build\fbthrift\source\.git\objects\pack\pack-250eb41d409d8c0f512fdb239d0225fa35d50c3d.idx'` Reviewed By: bigfootjon Differential Revision: D87655865 fbshipit-source-id: 8948b0ffe38f304fa96051bf6ac3a0455ef1a16e
meta-codesync bot
pushed a commit
to facebook/proxygen
that referenced
this pull request
Nov 24, 2025
Summary: X-link: facebook/watchman#1316 The upgrade of setuptools in D79195099 broke pywatchman build, Github windows CI erroring with `AttributeError: module 'setuptools.dist' has no attribute 'check_test_suite'` https://github.com/facebook/watchman/actions/runs/19440507973/job/55622405533#step:131:1188 . It was only affecting windows as only windows CI is building dependencies form source, the others use system dependencies. Fix by pinning watchman to the previous setuptools version Fix to help iterate locally: * fix the cargo.py remove behaviour to use rmtree_more. This fixes repeat local builds while debugging. After the first build was getting `PermissionError: [WinError 5] Access is denied: 'Z:\build\fbthrift\source\.git\objects\pack\pack-250eb41d409d8c0f512fdb239d0225fa35d50c3d.idx'` Reviewed By: bigfootjon Differential Revision: D87655865 fbshipit-source-id: 8948b0ffe38f304fa96051bf6ac3a0455ef1a16e
meta-codesync bot
pushed a commit
to facebook/openr
that referenced
this pull request
Nov 24, 2025
Summary: X-link: facebook/watchman#1316 The upgrade of setuptools in D79195099 broke pywatchman build, Github windows CI erroring with `AttributeError: module 'setuptools.dist' has no attribute 'check_test_suite'` https://github.com/facebook/watchman/actions/runs/19440507973/job/55622405533#step:131:1188 . It was only affecting windows as only windows CI is building dependencies form source, the others use system dependencies. Fix by pinning watchman to the previous setuptools version Fix to help iterate locally: * fix the cargo.py remove behaviour to use rmtree_more. This fixes repeat local builds while debugging. After the first build was getting `PermissionError: [WinError 5] Access is denied: 'Z:\build\fbthrift\source\.git\objects\pack\pack-250eb41d409d8c0f512fdb239d0225fa35d50c3d.idx'` Reviewed By: bigfootjon Differential Revision: D87655865 fbshipit-source-id: 8948b0ffe38f304fa96051bf6ac3a0455ef1a16e
meta-codesync bot
pushed a commit
to facebookincubator/cinderx
that referenced
this pull request
Nov 24, 2025
Summary: X-link: facebook/watchman#1316 The upgrade of setuptools in D79195099 broke pywatchman build, Github windows CI erroring with `AttributeError: module 'setuptools.dist' has no attribute 'check_test_suite'` https://github.com/facebook/watchman/actions/runs/19440507973/job/55622405533#step:131:1188 . It was only affecting windows as only windows CI is building dependencies form source, the others use system dependencies. Fix by pinning watchman to the previous setuptools version Fix to help iterate locally: * fix the cargo.py remove behaviour to use rmtree_more. This fixes repeat local builds while debugging. After the first build was getting `PermissionError: [WinError 5] Access is denied: 'Z:\build\fbthrift\source\.git\objects\pack\pack-250eb41d409d8c0f512fdb239d0225fa35d50c3d.idx'` Reviewed By: bigfootjon Differential Revision: D87655865 fbshipit-source-id: 8948b0ffe38f304fa96051bf6ac3a0455ef1a16e
meta-codesync bot
pushed a commit
to facebookexperimental/rust-shed
that referenced
this pull request
Nov 24, 2025
Summary: X-link: facebook/watchman#1316 The upgrade of setuptools in D79195099 broke pywatchman build, Github windows CI erroring with `AttributeError: module 'setuptools.dist' has no attribute 'check_test_suite'` https://github.com/facebook/watchman/actions/runs/19440507973/job/55622405533#step:131:1188 . It was only affecting windows as only windows CI is building dependencies form source, the others use system dependencies. Fix by pinning watchman to the previous setuptools version Fix to help iterate locally: * fix the cargo.py remove behaviour to use rmtree_more. This fixes repeat local builds while debugging. After the first build was getting `PermissionError: [WinError 5] Access is denied: 'Z:\build\fbthrift\source\.git\objects\pack\pack-250eb41d409d8c0f512fdb239d0225fa35d50c3d.idx'` Reviewed By: bigfootjon Differential Revision: D87655865 fbshipit-source-id: 8948b0ffe38f304fa96051bf6ac3a0455ef1a16e
meta-codesync bot
pushed a commit
to facebookincubator/katran
that referenced
this pull request
Nov 24, 2025
Summary: X-link: facebook/watchman#1316 The upgrade of setuptools in D79195099 broke pywatchman build, Github windows CI erroring with `AttributeError: module 'setuptools.dist' has no attribute 'check_test_suite'` https://github.com/facebook/watchman/actions/runs/19440507973/job/55622405533#step:131:1188 . It was only affecting windows as only windows CI is building dependencies form source, the others use system dependencies. Fix by pinning watchman to the previous setuptools version Fix to help iterate locally: * fix the cargo.py remove behaviour to use rmtree_more. This fixes repeat local builds while debugging. After the first build was getting `PermissionError: [WinError 5] Access is denied: 'Z:\build\fbthrift\source\.git\objects\pack\pack-250eb41d409d8c0f512fdb239d0225fa35d50c3d.idx'` Reviewed By: bigfootjon Differential Revision: D87655865 fbshipit-source-id: 8948b0ffe38f304fa96051bf6ac3a0455ef1a16e
meta-codesync bot
pushed a commit
to facebook/fbthrift
that referenced
this pull request
Nov 24, 2025
Summary: X-link: facebook/watchman#1316 The upgrade of setuptools in D79195099 broke pywatchman build, Github windows CI erroring with `AttributeError: module 'setuptools.dist' has no attribute 'check_test_suite'` https://github.com/facebook/watchman/actions/runs/19440507973/job/55622405533#step:131:1188 . It was only affecting windows as only windows CI is building dependencies form source, the others use system dependencies. Fix by pinning watchman to the previous setuptools version Fix to help iterate locally: * fix the cargo.py remove behaviour to use rmtree_more. This fixes repeat local builds while debugging. After the first build was getting `PermissionError: [WinError 5] Access is denied: 'Z:\build\fbthrift\source\.git\objects\pack\pack-250eb41d409d8c0f512fdb239d0225fa35d50c3d.idx'` Reviewed By: bigfootjon Differential Revision: D87655865 fbshipit-source-id: 8948b0ffe38f304fa96051bf6ac3a0455ef1a16e
meta-codesync bot
pushed a commit
to facebookexperimental/edencommon
that referenced
this pull request
Nov 24, 2025
Summary: X-link: facebook/watchman#1316 The upgrade of setuptools in D79195099 broke pywatchman build, Github windows CI erroring with `AttributeError: module 'setuptools.dist' has no attribute 'check_test_suite'` https://github.com/facebook/watchman/actions/runs/19440507973/job/55622405533#step:131:1188 . It was only affecting windows as only windows CI is building dependencies form source, the others use system dependencies. Fix by pinning watchman to the previous setuptools version Fix to help iterate locally: * fix the cargo.py remove behaviour to use rmtree_more. This fixes repeat local builds while debugging. After the first build was getting `PermissionError: [WinError 5] Access is denied: 'Z:\build\fbthrift\source\.git\objects\pack\pack-250eb41d409d8c0f512fdb239d0225fa35d50c3d.idx'` Reviewed By: bigfootjon Differential Revision: D87655865 fbshipit-source-id: 8948b0ffe38f304fa96051bf6ac3a0455ef1a16e
meta-codesync bot
pushed a commit
to facebookincubator/hsthrift
that referenced
this pull request
Nov 24, 2025
Summary: X-link: facebook/watchman#1316 The upgrade of setuptools in D79195099 broke pywatchman build, Github windows CI erroring with `AttributeError: module 'setuptools.dist' has no attribute 'check_test_suite'` https://github.com/facebook/watchman/actions/runs/19440507973/job/55622405533#step:131:1188 . It was only affecting windows as only windows CI is building dependencies form source, the others use system dependencies. Fix by pinning watchman to the previous setuptools version Fix to help iterate locally: * fix the cargo.py remove behaviour to use rmtree_more. This fixes repeat local builds while debugging. After the first build was getting `PermissionError: [WinError 5] Access is denied: 'Z:\build\fbthrift\source\.git\objects\pack\pack-250eb41d409d8c0f512fdb239d0225fa35d50c3d.idx'` Reviewed By: bigfootjon Differential Revision: D87655865 fbshipit-source-id: 8948b0ffe38f304fa96051bf6ac3a0455ef1a16e
meta-codesync bot
pushed a commit
to facebookincubator/fizz
that referenced
this pull request
Nov 24, 2025
Summary: X-link: facebook/watchman#1316 The upgrade of setuptools in D79195099 broke pywatchman build, Github windows CI erroring with `AttributeError: module 'setuptools.dist' has no attribute 'check_test_suite'` https://github.com/facebook/watchman/actions/runs/19440507973/job/55622405533#step:131:1188 . It was only affecting windows as only windows CI is building dependencies form source, the others use system dependencies. Fix by pinning watchman to the previous setuptools version Fix to help iterate locally: * fix the cargo.py remove behaviour to use rmtree_more. This fixes repeat local builds while debugging. After the first build was getting `PermissionError: [WinError 5] Access is denied: 'Z:\build\fbthrift\source\.git\objects\pack\pack-250eb41d409d8c0f512fdb239d0225fa35d50c3d.idx'` Reviewed By: bigfootjon Differential Revision: D87655865 fbshipit-source-id: 8948b0ffe38f304fa96051bf6ac3a0455ef1a16e
meta-codesync bot
pushed a commit
to facebook/sapling
that referenced
this pull request
Nov 24, 2025
Summary: X-link: facebook/watchman#1316 The upgrade of setuptools in D79195099 broke pywatchman build, Github windows CI erroring with `AttributeError: module 'setuptools.dist' has no attribute 'check_test_suite'` https://github.com/facebook/watchman/actions/runs/19440507973/job/55622405533#step:131:1188 . It was only affecting windows as only windows CI is building dependencies form source, the others use system dependencies. Fix by pinning watchman to the previous setuptools version Fix to help iterate locally: * fix the cargo.py remove behaviour to use rmtree_more. This fixes repeat local builds while debugging. After the first build was getting `PermissionError: [WinError 5] Access is denied: 'Z:\build\fbthrift\source\.git\objects\pack\pack-250eb41d409d8c0f512fdb239d0225fa35d50c3d.idx'` Reviewed By: bigfootjon Differential Revision: D87655865 fbshipit-source-id: 8948b0ffe38f304fa96051bf6ac3a0455ef1a16e
meta-codesync bot
pushed a commit
to facebook/wangle
that referenced
this pull request
Nov 24, 2025
Summary: X-link: facebook/watchman#1316 The upgrade of setuptools in D79195099 broke pywatchman build, Github windows CI erroring with `AttributeError: module 'setuptools.dist' has no attribute 'check_test_suite'` https://github.com/facebook/watchman/actions/runs/19440507973/job/55622405533#step:131:1188 . It was only affecting windows as only windows CI is building dependencies form source, the others use system dependencies. Fix by pinning watchman to the previous setuptools version Fix to help iterate locally: * fix the cargo.py remove behaviour to use rmtree_more. This fixes repeat local builds while debugging. After the first build was getting `PermissionError: [WinError 5] Access is denied: 'Z:\build\fbthrift\source\.git\objects\pack\pack-250eb41d409d8c0f512fdb239d0225fa35d50c3d.idx'` Reviewed By: bigfootjon Differential Revision: D87655865 fbshipit-source-id: 8948b0ffe38f304fa96051bf6ac3a0455ef1a16e
meta-codesync bot
pushed a commit
to facebook/hhvm
that referenced
this pull request
Nov 24, 2025
Summary: X-link: facebook/watchman#1316 The upgrade of setuptools in D79195099 broke pywatchman build, Github windows CI erroring with `AttributeError: module 'setuptools.dist' has no attribute 'check_test_suite'` https://github.com/facebook/watchman/actions/runs/19440507973/job/55622405533#step:131:1188 . It was only affecting windows as only windows CI is building dependencies form source, the others use system dependencies. Fix by pinning watchman to the previous setuptools version Fix to help iterate locally: * fix the cargo.py remove behaviour to use rmtree_more. This fixes repeat local builds while debugging. After the first build was getting `PermissionError: [WinError 5] Access is denied: 'Z:\build\fbthrift\source\.git\objects\pack\pack-250eb41d409d8c0f512fdb239d0225fa35d50c3d.idx'` Reviewed By: bigfootjon Differential Revision: D87655865 fbshipit-source-id: 8948b0ffe38f304fa96051bf6ac3a0455ef1a16e
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
The upgrade of setuptools in D79195099 broke pywatchman build, Github windows CI erroring with
AttributeError: module 'setuptools.dist' has no attribute 'check_test_suite'https://github.com/facebook/watchman/actions/runs/19440507973/job/55622405533#step:131:1188 . It was only affecting windows as only windows CI is building dependencies form source, the others use system dependencies.Fix by pinning watchman to the previous setuptools version
Fix to help iterate locally:
PermissionError: [WinError 5] Access is denied: 'Z:\build\fbthrift\source\.git\objects\pack\pack-250eb41d409d8c0f512fdb239d0225fa35d50c3d.idx'Differential Revision: D87655865