IdNumber - Dutch BSN generator#3102
Conversation
|
|
||
| PLATFORMS | ||
| arm64-darwin-22 | ||
| arm64-darwin-24 |
There was a problem hiding this comment.
This was added automatically, and I try to refrain from manually removing lines from the lock file.
Question for the Faker maintainers: Should this change be removed or let it?
|
Hi @Fonzie-byte Thanks for your contribution. I know working on Open Source requires valuable time. At the moment, we won't accept this because we are not introducing new/significant changes to existing generators. @thdaraujo and I are currently exploring different ways of loading the generators with the expectation to give the community the option to create their own generators/custom options without merging them in faker. This would reduce our load (we have lots of generators to update, maintain, etc.) while providing flexibility to users by adding external plugins. Once we have this going, I will let you know and you can contribute to faker by adding this option as a plugin. Closing in the meantime since we are focused on improving the existing ones. |
Motivation / Background
This Pull Request has been created because a generator for Dutch national ID numbers (called Burger Service Nummer, or BSN for short) was missing.
I know you are not looking for new generators, but I hope you will still consider something this useful.
Additional information
Sample terminal output:
Checklist
Before submitting the PR make sure the following are checked:
[Fix #issue-number]If you're proposing a new generator or locale: