fix: authenticate protected PWA manifest requests - #571
Open
Tokra110 wants to merge 1 commit into
Open
Conversation
📝 WalkthroughWalkthroughThe layout removes the manifest entry from generated metadata. It adds a document-level manifest link that targets 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Tokra110
marked this pull request as ready for review
August 3, 2026 20:48
fccview
reviewed
Aug 4, 2026
| > | ||
| <head> | ||
| {process.env.NODE_ENV === "development" && <SuppressWarnings />} | ||
| {/* fccview is onto you! */} |
Owner
There was a problem hiding this comment.
whops 😆
Mind removing this and I'll approve? ❤️
Tokra110
force-pushed
the
agent/authenticated-pwa-manifest
branch
from
August 4, 2026 12:50
abcfc5e to
50c342b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why this change is needed
Jotty can be deployed behind an authentication reverse proxy that protects every application path, including the web app manifest.
In this setup, a browser may create a normal home-screen shortcut instead of offering to install Jotty as a PWA.
The browser requests Jotty's app manifest without the existing login credentials. The authentication proxy redirects that request to its login page, so the browser cannot recognize Jotty as an installable app.
What this changes
This change tells the browser to include the existing login credentials when it requests
/api/manifest.For normal Jotty installations, the manifest URL and behavior stay the same. For installations protected by an authentication reverse proxy, the browser can now read the manifest and offer the proper PWA installation instead of only creating a shortcut.
Type of change (pick one or more if needed)
Please check the following:
developand I am targetingdevelopfor this PR. (Code directed tomainwill be closed).howto/TRANSLATIONS.md).app/_components/GlobalComponents/orFeatureComponents/instead of creating duplicates.Validation
yarn lintyarn tsc --noEmityarn test:run tests/security --reporter=verbose(39 tests)yarn test:run tests/api --reporter=verbose(141 tests)yarn test:run tests/server-actions --reporter=verbose(459 tests)yarn buildcrossorigin="use-credentials".Summary by CodeRabbit