Check for the python(prerel-abi) requirement #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hroncok
reviewed
Dec 9, 2025
jobs.py
Outdated
| if 'python(prerel-abi)' in req_str: | ||
| # Try to find if this requirement can be satisfied | ||
| selector = hawkey.Selector(sack).set(provides=req_str) | ||
| matching_packages = selector.matches() |
Member
There was a problem hiding this comment.
I think that this will happily find all older Python builds regardless of the version.
Maybe the config file should specify the version you want?
Some packages require python(prerel-abi) = X.Y.Z~alphaN which may not match the prerel-abi version currently available in the target repo. These packages need to be treated as "not yet successfully rebuilt" even though they depend on the new Python ABI and exist in the target. This change adds filtering logic that: - Checks all packages in components_done for unsatisfied prerel-abi deps - Removes components with mismatched prerel-abi from components_done - Allows them to be reported as ready to rebuild - Tracks blocked components for proper status reporting Assisted-By: Claude 4.5 Sonnet
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on the refactor proposed in the other PR. Only the last commit differs. This adds a check to prerel-abi outside of the main resolve loop. I'm too lost in the woods to find a better way.