fix(typescript,vueTsc): quote the project path passed to tsc - #792
Open
Artur- wants to merge 1 commit into
Open
Conversation
Checker binaries are spawned through a shell, which splits the command on whitespace. The typescript and vueTsc checkers build the project path themselves from `root` and `tsconfigPath`, so a project living under a directory with a space in its name reached tsc as two arguments and failed with "TS5042: Option 'project' cannot be mixed with source files on a command line". Quote the constructed path, per platform, since cmd.exe understands only double quotes while POSIX shells keep expanding inside them. Arguments that come from a user supplied `lintCommand` are left untouched: they are already split on spaces and carry their own quoting. The same splitting applied to the fallback that runs `tsc` from PATH when the TypeScript package exposes no compiler API, as with TypeScript 7, so quote those arguments as well.
✅ Deploy Preview for vite-plugin-checker ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
commit: |
This was referenced Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checker binaries are spawned through a shell, which splits the command on whitespace. The typescript and vueTsc checkers build the project path themselves from
rootandtsconfigPath, so a project living under a directory with a space in its name reached tsc as two arguments and failed with "TS5042: Option 'project' cannot be mixed with source files on a command line".Quote the constructed path, per platform, since cmd.exe understands only double quotes while POSIX shells keep expanding inside them. Arguments that come from a user supplied
lintCommandare left untouched: they are already split on spaces and carry their own quoting.The same splitting applied to the fallback that runs
tscfrom PATH when the TypeScript package exposes no compiler API, as with TypeScript 7, so quote those arguments as well.