avoid memory allocation from the heap class.#2224
Merged
Merged
Conversation
vishramachandran
approved these changes
May 8, 2026
yu-shipit
added a commit
to yu-shipit/FiloDB
that referenced
this pull request
May 8, 2026
* avoid memory allocation from the heap class. * fix timestamp for all NaN cases. --------- Co-authored-by: Yu Zhang <yzhang999272@apple.com>
yu-shipit
added a commit
that referenced
this pull request
May 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
🚀 Performance Optimization: Avoid Memory Allocation from Heap Class
Commit Details
a86d5bddb7fbebc4aea4dc29ae486e2adf7eb190integration(HEAD → integration, origin/integration)📋 Summary
This commit introduces a significant performance optimization by removing helper functions that caused unnecessary memory allocations and replacing them with inline NaN handling logic. This change improves performance in time-series aggregation functions while maintaining correct NaN handling behavior.
🔧 Changes Made
Primary Changes
1. ✅ Removed Helper Functions to Avoid Memory Allocation
Eliminated three helper functions from
QueryUtilsthat were causing heap allocations:maxIgnoreNaN(a: Double, aTs: Long, b: Double, bTs: Long): (Double, Long)minIgnoreNaN(a: Double, aTs: Long, b: Double, bTs: Long): (Double, Long)lastIgnoreNaN(a: Double, aTs: Long, b: Double, bTs: Long): (Double, Long)Why this improves performance:
(Double, Long)on the heap2. ✅ Inlined NaN Handling Logic
Replaced function calls with direct inline logic in
MinOverTimeChunkedFunctionD:Before (heap allocation):
After (no allocation):
BREAKING CHANGES
If this PR contains a breaking change, please describe the impact and migration
path for existing applications.
If not please remove this section.
Breaking changes may include:
Other information: