Skip to content

Fix: Allow input prop to override field.input (#1048) #1067

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
erikras-dinesh-agent wants to merge 1 commit into from
+1 −1
Closed

Fix: Allow input prop to override field.input (#1048) #1067

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Field.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ function FieldComponent<
}

return renderComponent(
{ children, component, ...rest, ...field },
{ children, component, ...field, ...rest },
{},
Comment on lines 88 to 90
Copy link

@coderabbitai coderabbitai bot Feb 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick | 🔵 Trivial

Add a regression test for input prop override.

Please add a test that passes input={{ value: "foo" }} to <Field> and asserts the rendered component receives it, so this regression doesn’t return.

🤖 Prompt for AI Agents 
In `@src/Field.tsx` around lines 88 - 90, Add a regression test to ensure the
Field component forwards an input prop override: write a test that renders the
Field component (the component that calls renderComponent) with prop input={{
value: "foo" }} and a simple stub child/component, then assert the rendered
child/component receives that exact input prop (e.g., via props or DOM output)
to prevent future regressions in the renderComponent call path. Target the Field
component (the function that returns renderComponent({ children, component,
...field, ...rest }, {})) and verify the forwarded input prop is preserved.

`Field(${name})`,
);
Expand Down
Loading