Ensure NuGet recovery publishes - #226
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
Ensure NuGet-only release recovery reaches the publish job after intentionally skipping platform artifact builds.
Root cause
GitHub Actions applies an implicit
success()condition to jobs without a status-check function. In NuGet recovery mode, the artifact matrix is intentionally skipped. The package job overrides that skip propagation and succeeds, but the downstream publish job inherited the skipped ancestor and was reported as skipped, leaving the workflow falsely green without publishing either feed.Change
Add an explicit job condition that:
Full releases remain transitively gated on successful platform builds through the package job.
Behavior impact
A
workflow_dispatchrun withrecovery_mode=nugetnow executes NuGet.org and GitHub Packages publication after reusing and verifying the immutable release package. Normal full releases retain their existing build and publication gates.Validation
./scripts/sync-surge-core-vendor.sh --check./scripts/check-version-sync.shcargo fmt --all -- --checkRUSTFLAGS="-D warnings" cargo test --workspacecargo clippy --all-targets --all-features -- -D warningscargo clippy --workspace --lib --bins --examples -- -D warnings -D clippy::unwrap_used -D clippy::expect_usedcargo clippy --workspace --all-targets --all-features -- -D warnings -W clippy::pedanticdotnet format dotnet/Surge.slnx --verify-no-changesdotnet test dotnet/Surge.slnx --configuration Releaseactionlint .github/workflows/release.ymlgit diff --checkMigration
No migration is required.