Skip to content

chore: prune unused upstream build config and Go dependencies#34

Merged
ncooke3 merged 1 commit into
mainfrom
nc.cleanup
Jun 24, 2026
Merged

chore: prune unused upstream build config and Go dependencies#34
ncooke3 merged 1 commit into
mainfrom
nc.cleanup

Conversation

@ncooke3

@ncooke3 ncooke3 commented Jun 23, 2026

Copy link
Copy Markdown
Member

Removes CMakeLists.txt, the cmake/ directory, go.mod, and go.sum. These files are remnants from the upstream BoringSSL repository that are not required for Swift Package Manager. As per the Maintenance & Sync Guide, any files not explicitly referenced in Package.swift are considered dead code and should be removed to reduce package bloat.

b/526986177

Removes `CMakeLists.txt`, the `cmake/` directory, `go.mod`, and `go.sum`.
These files are remnants from the upstream BoringSSL repository that
are not required for Swift Package Manager. As per the Maintenance & Sync
Guide, any files not explicitly referenced in `Package.swift` are
considered dead code and should be removed to reduce package bloat.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request deletes several build configuration and dependency files, including the main CMakeLists.txt, CMake helper modules (OpenSSLConfig.cmake, go.cmake, and paths.cmake), and Go module files (go.mod and go.sum). There are no review comments, and I have no feedback to provide.

@ncooke3

ncooke3 commented Jun 23, 2026

Copy link
Copy Markdown
Member Author

These changes will not affect grpc-ios.

Here is the breakdown of why this is safe:

  • No CMake Usage: The grpc-ios repository does not use CMake as its build system. It lacks a CMakeLists.txt file and does not invoke CMake in any of its build scripts or configuration files (Package.swift, .podspec, etc.).
  • Strictly SPM & CocoaPods: The grpc-ios repository consumes boringSSL-SwiftPM exclusively via Swift Package Manager (using Package.swift) and CocoaPods (using gRPC-Core.podspec).
  • Native Compilation: Both Swift Package Manager and CocoaPods pull the boringSSL-SwiftPM source files and compile the C/C++ code natively using the platform's native build system. They completely ignore upstream build artifacts like CMakeLists.txt, go.mod, or .go scripts.

@ncooke3 ncooke3 requested a review from cherylEnkidu June 23, 2026 23:22
@ncooke3 ncooke3 merged commit bb83837 into main Jun 24, 2026
17 checks passed
@ncooke3

ncooke3 commented Jun 24, 2026

Copy link
Copy Markdown
Member Author

cc: @aslam9691

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants