chore: prune unused upstream build config and Go dependencies#34
Merged
Conversation
Removes `CMakeLists.txt`, the `cmake/` directory, `go.mod`, and `go.sum`. These files are remnants from the upstream BoringSSL repository that are not required for Swift Package Manager. As per the Maintenance & Sync Guide, any files not explicitly referenced in `Package.swift` are considered dead code and should be removed to reduce package bloat.
Contributor
There was a problem hiding this comment.
Code Review
This pull request deletes several build configuration and dependency files, including the main CMakeLists.txt, CMake helper modules (OpenSSLConfig.cmake, go.cmake, and paths.cmake), and Go module files (go.mod and go.sum). There are no review comments, and I have no feedback to provide.
This was referenced Jun 23, 2026
Member
Author
|
These changes will not affect grpc-ios. Here is the breakdown of why this is safe:
|
paulb777
approved these changes
Jun 23, 2026
Member
Author
|
cc: @aslam9691 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes
CMakeLists.txt, thecmake/directory,go.mod, andgo.sum. These files are remnants from the upstream BoringSSL repository that are not required for Swift Package Manager. As per the Maintenance & Sync Guide, any files not explicitly referenced inPackage.swiftare considered dead code and should be removed to reduce package bloat.b/526986177