Skip to content

docs: update CONTRIBUTING to use npm/pnpm (remove yarn)#585

Open
White-Devil347 wants to merge 1 commit into
firstcontributions:mainfrom
White-Devil347:White-devil347
Open

docs: update CONTRIBUTING to use npm/pnpm (remove yarn)#585
White-Devil347 wants to merge 1 commit into
firstcontributions:mainfrom
White-Devil347:White-devil347

Conversation

@White-Devil347
Copy link
Copy Markdown

No description provided.

@White-Devil347
Copy link
Copy Markdown
Author

docs: update CONTRIBUTING to use npm/pnpm (remove yarn)

@Sean-Kenneth-Doherty
Copy link
Copy Markdown

I reviewed this CONTRIBUTING update and it looks directionally good.

Checks run:

  • git diff --check main...HEAD passes
  • compared the commands against the current package.json scripts (dev and build) and the README, which already documents npm/pnpm instead of yarn

The important corrections are right: yarn start and port 3000 are stale for this Astro app, while npm run dev / pnpm dev and port 4321 match the current project.

Small non-blocking polish: I would lowercase “Dependencies” in “install the required Dependencies” while this section is being touched.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants