Skip to content

Add Dinesh Sivalanka#589

Open
DineshSivalanka wants to merge 1 commit into
firstcontributions:mainfrom
DineshSivalanka:Dinesh
Open

Add Dinesh Sivalanka#589
DineshSivalanka wants to merge 1 commit into
firstcontributions:mainfrom
DineshSivalanka:Dinesh

Conversation

@DineshSivalanka
Copy link
Copy Markdown

Added my name to the Contributors list.

@DineshSivalanka
Copy link
Copy Markdown
Author

Added my name to the Contributors list.

@Sean-Kenneth-Doherty
Copy link
Copy Markdown

This PR does not look like a good fit for this repository as written. It appends --Dinesh Sivalanka to the end of CONTRIBUTING.md, which is the project setup guide, not a contributor list. It also leaves extra blank lines and no final newline.

If the goal is to make a first contribution here, I would rework this into a focused docs/site fix tied to an open issue instead of adding a personal signature to the contribution instructions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants