#673 (InStore App issue) eliminate state field from issue delivered r…#20
Merged
1 commit merged intoMay 18, 2026
mainfrom
Conversation
…esponse as it is not guaranteed to stay stable in the future
There was a problem hiding this comment.
Pull request overview
This PR updates the issue-delivery response DTO to remove the explicit state field and adjusts the HOWTO sample to log the remaining delivery message.
Changes:
- Replaced lowercase
messageDTO property with PascalCaseMessagemapped to JSONmessage. - Added extension-data support for arbitrary response fields.
- Updated the issue-delivery HOWTO debug log and ignored
*.lscachefiles.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
libPosSystemAPI/DTO/IssueDeliveredResponse.cs |
Removes state, introduces Message, and captures unknown JSON fields. |
HOWTO_08_pay_sign_issue_csharp/Program.cs |
Updates logging to use the revised delivery response DTO. |
.gitignore |
Adds an ignore rule for *.lscache files. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+16
to
+18
| public string Message { get; set; } = string.Empty; | ||
|
|
||
| /// <summary> |
deboragracio
approved these changes
May 15, 2026
MaximilianFT
deleted the
673-pos-system-api-docs-remove-state-field-from-get-issue-request-as-it-is-not-final-and-might-change-in-future
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.