chore(playbook): do not use single transaction to enable streaming

[yashmehrotra]

Summary by CodeRabbit

• Bug Fixes
  • Automatically reaps and resets orphaned/stalled playbook actions back to a schedulable state after the configured timeout.
  • More consistently updates action status on pre-execution issues (fails vs. reschedules) instead of leaving ambiguous results.
• Reliability
  • Improves playbook action claiming so actions are marked as “running” before execution, reducing race/transaction delays.
  • Provides more immediate streaming updates for scheduled action execution.
• Tests
  • Adds coverage for claiming behavior, orphan reaping rules, and streaming/log expectations.

[coderabbitai]

Warning

Review limit reached

@yashmehrotra, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 29 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 887d1fac-2645-45a0-a512-77bf63c7066a

📥 Commits

Reviewing files that changed from the base of the PR and between ba509fc and 5ad07fe.

📒 Files selected for processing (6)

• jobs/jobs.go
• jobs/playbook.go
• playbook/jobs.go
• playbook/run_consumer.go
• playbook/run_consumer_test.go
• playbook/runner/runner.go

Walkthrough

Playbook consumers now claim actions in short transactions and execute them afterward. Pre-execution errors produce explicit failed or rescheduled states. A recurring job resets orphaned actions, with tests covering claims, failures, streaming, retries, and reaping.

Changes

Playbook action lifecycle

Layer / File(s)	Summary
Claim-then-execute consumers playbook/run_consumer.go, playbook/run_consumer_test.go	Agent and scheduled actions commit their running claim before execution; failures are handled after rechecking current status, and tests cover streaming and subsequent claims.
Pre-execution error transitions playbook/runner/runner.go	Missing or invalid playbook data marks actions failed, while other playbook lookup errors reschedule actions.
Orphan reaper and scheduling playbook/jobs.go, jobs/playbook.go, jobs/jobs.go, playbook/run_consumer_test.go	A recurring singleton job resets eligible orphaned actions to waiting or scheduled states, with parent-run and timeout checks covered by tests.

Sequence Diagram(s)

sequenceDiagram
  participant ActionConsumer
  participant claimNextAction
  participant runner.RunAction
  participant failClaimedAction
  ActionConsumer->>claimNextAction: Claim and start scheduled action
  claimNextAction-->>ActionConsumer: Return running action and playbook run
  ActionConsumer->>runner.RunAction: Execute outside transaction
  runner.RunAction-->>ActionConsumer: Return result or error
  ActionConsumer->>failClaimedAction: Mark still-running action failed

Loading

Possibly related PRs

• flanksource/mission-control#3239: Also changes RunAction handling of failed and retried PlaybookRunAction states.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 40.91% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (4 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Title check	✅ Passed	The title clearly matches the main change: splitting playbook action execution out of a single transaction to support streaming.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

• Create stacked PR
• Commit on current branch

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch streaming-fix

✨ Simplify code

• Create PR with simplified code
• Commit simplified code in branch streaming-fix

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}

[coderabbitai]

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents

Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@playbook/jobs.go`:
- Around line 156-186: Update ReapOrphanedActions and the local action-claim
flow to prevent reclaiming a locally executing action before its claim can
finish. Ensure the effective local claim timeout is always shorter than
playbook.action.orphan_timeout, or add a liveness/heartbeat check or in-flight
claim-timeout condition so the reaper excludes active claims; preserve reaping
behavior for genuinely orphaned actions.

🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

• Push a commit to this branch (recommended)
• Create a new PR with the fixes

---

ℹ️ Review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: ef0a8230-c1dc-423a-8ca3-cc41f31d1c3c

📥 Commits

Reviewing files that changed from the base of the PR and between 8231e97 and 60027fa.

📒 Files selected for processing (6)

• jobs/jobs.go
• jobs/playbook.go
• playbook/jobs.go
• playbook/run_consumer.go
• playbook/run_consumer_test.go
• playbook/runner/runner.go