Remove enclosed_entities from UDF#1900
Merged
benflexcompute merged 7 commits intomainfrom Mar 16, 2026
Merged
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
benflexcompute
approved these changes
Mar 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

After #1860, some localTests broke because they needed enclosed_entities on dummy UserDefinedFarfields used with CustomVolumes.
This PR reverts #1889, which attempted to fix the above by allowing CVs to be used without UDF. We'll allow this later, but aren't confident we can support this yet (need: move domain_type from farfield to MeshingParams; check any places that may be broken by the lack of a farfield)
This PR also removes enclosed_entities from UDF, because it makes less sense to specify just the inner boundaries of the farfield when the outer one is not auto generated (unlike Auto or WT). To achieve the same functionality, currently, the user should create a CV with both the inner and outer boundaries of the farfield volume (mesher seems to silently lose the outer geometry otherwise?).
bonus barely-related fix: now that CustomZone can be used with WindTunnel, the WT zone is not necessarily at index 0
Note
Medium Risk
Tightens meshing schema/validation around farfield/custom-volume setup and changes translation/validation behavior, which can break existing configs that relied on implicit farfield or
UserDefinedFarfield.enclosed_entities. Scope is contained to meshing parameter models, translators, and related validators/tests.Overview
UserDefinedFarfieldno longer acceptsenclosed_entities. Support forenclosed_entitiesis moved behind a new_FarfieldAllowingEnclosedEntitiesbase used only byAutomatedFarfieldandWindTunnelFarfield, and all validators/translators now only read/emit farfield patch data from those types.Volume zone validation is tightened.
MeshingParams.volume_zonesnow always requires an explicit farfield zone (no more CustomVolumes-only/implicit farfield), andfarfield_methodinference no longer treatsCustomZonesas implicitly user-defined in the non-modular workflow.Validation/translation fixes and test updates. Wind-tunnel boundary collection no longer assumes the wind-tunnel zone is at index 0, farfield-enclosed-entity extraction skips UDF, and tests are updated/added to assert UDF rejects extra fields and that translations omit the synthetic
farfieldzone when no supportedenclosed_entitiesare present.Written by Cursor Bugbot for commit 6a24e6c. This will update automatically on new commits. Configure here.