Skip to content

Scheduled sync: main → develop#1914

Merged
github-actions[bot] merged 3 commits intodevelopfrom
main
Mar 19, 2026
Merged

Scheduled sync: main → develop#1914
github-actions[bot] merged 3 commits intodevelopfrom
main

Conversation

@github-actions
Copy link
Contributor

@github-actions github-actions bot commented Mar 19, 2026

Automated sync needs review:

  • Merge conflicted: true
  • Direct push exit code: n/a
    Please resolve and merge to bring develop up to date with main.

Note

Medium Risk
Adds new runtime guardrails around ImportedSurface usage and entity private_attribute_id requirements, which can cause previously-accepted calls to raise errors if callers relied on implicit behavior. Also changes how ImportedSurface ids are generated, which may affect persistence/lookup semantics across sessions.

Overview
Tightens DraftContext requirements for imported surface dependencies. Project._run() now raises a Flow360ValueError when SimulationParams.private_attribute_asset_cache.imported_surfaces is non-empty but no active DraftContext exists, preventing submissions that would otherwise proceed with inconsistent draft-dependent state.

Hardens entity tracking for draft features. CoordinateSystemManager.assign() and MirrorManager.create_mirror_of() now reject entities with private_attribute_id=None, and ImportedSurface auto-populates a deterministic private_attribute_id derived from name to keep coordinate-system/mirror bookkeeping stable across reconstructions.

Tests updated/added to cover the new guard clause, the new error paths for id-less entities, and deterministic ImportedSurface id behavior.

Written by Cursor Bugbot for commit 5b9ea2b. This will update automatically on new commits. Configure here.

github-actions bot and others added 3 commits March 19, 2026 14:17
…d without DraftContext (#1909)

Co-authored-by: Ben <106089368+benflexcompute@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…t before draft submission (#1911)

Co-authored-by: Ben <106089368+benflexcompute@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… & entity ID guard checks (#1912)

Co-authored-by: Ben <106089368+benflexcompute@users.noreply.github.com>
Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@github-actions github-actions bot merged commit 3eb4cc6 into develop Mar 19, 2026
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant