Scheduled sync: main → develop#1914
Merged
github-actions[bot] merged 3 commits intodevelopfrom Mar 19, 2026
Merged
Conversation
…d without DraftContext (#1909) Co-authored-by: Ben <106089368+benflexcompute@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…t before draft submission (#1911) Co-authored-by: Ben <106089368+benflexcompute@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
… & entity ID guard checks (#1912) Co-authored-by: Ben <106089368+benflexcompute@users.noreply.github.com> Co-authored-by: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
benflexcompute
approved these changes
Mar 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automated sync needs review:
Please resolve and merge to bring
developup to date withmain.Note
Medium Risk
Adds new runtime guardrails around
ImportedSurfaceusage and entityprivate_attribute_idrequirements, which can cause previously-accepted calls to raise errors if callers relied on implicit behavior. Also changes howImportedSurfaceids are generated, which may affect persistence/lookup semantics across sessions.Overview
Tightens DraftContext requirements for imported surface dependencies.
Project._run()now raises aFlow360ValueErrorwhenSimulationParams.private_attribute_asset_cache.imported_surfacesis non-empty but no activeDraftContextexists, preventing submissions that would otherwise proceed with inconsistent draft-dependent state.Hardens entity tracking for draft features.
CoordinateSystemManager.assign()andMirrorManager.create_mirror_of()now reject entities withprivate_attribute_id=None, andImportedSurfaceauto-populates a deterministicprivate_attribute_idderived fromnameto keep coordinate-system/mirror bookkeeping stable across reconstructions.Tests updated/added to cover the new guard clause, the new error paths for id-less entities, and deterministic
ImportedSurfaceid behavior.Written by Cursor Bugbot for commit 5b9ea2b. This will update automatically on new commits. Configure here.