Ben y/expresssion migration#1915
Draft
benflexcompute wants to merge 3 commits intoBenY/CentralizedSchemafrom
Draft
Ben y/expresssion migration#1915benflexcompute wants to merge 3 commits intoBenY/CentralizedSchemafrom
benflexcompute wants to merge 3 commits intoBenY/CentralizedSchemafrom
Conversation
- Delete blueprint shim files, import directly from flow360_schema - Rename .set() -> .set_value() calls on EvaluationContext - Add logging bridge in flow360/log.py to route schema stdlib logging through Flow360's rich Logger - Update all imports in user_code, services, outputs, and tests Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Replace context.py, utils.py, control.py, solution.py, math.py with re-imports from flow360-schema - Rewrite types.py: import core classes from schema, create temporary client subclasses (Variable, UserVariable, Expression) for validators not yet migrated (ValueOrExpression, legacy name check, feature check) - Update all to_solver_code(params) calls to to_solver_code(params.flow360_unit_system) - Update isinstance checks to use ExpressionBase/VariableBase for schema compatibility - Fix engine/ import paths (expression.parser → expression.engine.parser) - Fix pylint warnings on re-export files Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
- Re-import SerializedValueOrExpression, UnytArray, UnytQuantity, AnyNumericType from schema value_or_expression - Register deprecation_reminder callback via register_deprecation_check - Restore legacy output field error messages for velocity/mut/pressure - Add MIGRATION-TODO for _SchemaVariable isinstance guard - Fix pylint unused-import and wrong-import-position Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.