[doctrings]: clarification for initial blade direction#1916
Merged
marcvivesmassana merged 2 commits intomainfrom Mar 20, 2026
Merged
[doctrings]: clarification for initial blade direction#1916marcvivesmassana merged 2 commits intomainfrom
marcvivesmassana merged 2 commits intomainfrom
Conversation
piotrkluba
approved these changes
Mar 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Low Risk
Docstring-only changes clarifying how
BETDisk.initial_blade_directionshould be interpreted; no runtime logic or validation behavior is modified.Overview
Clarifies the meaning and requirements of
BETDisk.initial_blade_directioninvolume_models.py, explicitly stating it is a global mesh-frame direction (not a disk-local frame), must be orthogonal toCylinder.axis, and is required for unsteady BET Line whenblade_line_chord > 0.Updates the corresponding parameter docs in the
BETDiskconstructors to match this clarified definition.Written by Cursor Bugbot for commit 7a4fc1a. This will update automatically on new commits. Configure here.