fix(issues): include project, cycle, parent, milestone in issues read#150
Merged
Merged
Conversation
IssueDetail selected state/assignee/team but never project, cycle, parent, or projectMilestone, so the generated GraphQL query never requested them and issues read omitted the keys entirely (not null — absent). Add ProjectRef/MilestoneRef/CycleRef ref types and wire the four fields onto IssueDetail; the GraphQLFields derive selects and serializes them automatically. Closes #149
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #149.
lineark issues read <ID>never returned the issue's project (norcycle,parent, orprojectMilestone) — the keys were entirely absent from the output, not null.IssueDetail(the zero-overfetch type whose shape is the GraphQL query shape) selectedstate/assignee/teambut had noproject/cycle/parent/projectMilestonefields, so the generated query never requested them.Changes
ProjectRef,MilestoneRef, andCycleRefnested ref types (mirroring the existingTeamRef/StateRefpattern).project,project_milestone,cycle, andparent(reusingRelatedIssueRef) ontoIssueDetail. TheGraphQLFieldsderive wires both the query and the serialized output automatically.issues readhelp text andusagereference to mention project.Both
--format jsonand--format humannow surface these associations (human renderer skips null fields; JSON includes them as null when absent).Test plan
make check✅make test(offline) ✅ — 47 passedissues_read_json_includes_estimate_fieldto assert theproject,projectMilestone,cycle, andparentkeys are present. Ran against the live API ✅ — 1 passed.