Skip to content

fix(gmail): empty provider, login - #1703

Open
andrinoff wants to merge 1 commit into
floatpane:masterfrom
andrinoff:fix/gmail-issues
Open

fix(gmail): empty provider, login#1703
andrinoff wants to merge 1 commit into
floatpane:masterfrom
andrinoff:fix/gmail-issues

Conversation

@andrinoff

Copy link
Copy Markdown
Member

What?

Fixes several issues with Gmail

Why?

Fixes #1674

Signed-off-by: drew <me@andrinoff.com>
@andrinoff
andrinoff requested a review from a team as a code owner August 1, 2026 09:54
@floatpanebot floatpanebot added area/fetcher IMAP fetch / IDLE / search area/sender SMTP send path area/config Configuration / settings area/daemon Daemon / RPC bug Something isn't working size/L Diff: 201–800 lines labels Aug 1, 2026
@floatpanebot

Copy link
Copy Markdown
Member

Benchmark report — no significant change

Metrics worse: 0 · better: 0 (threshold: ±3%).

benchstat output
goos: linux
goarch: amd64
pkg: github.com/floatpane/matcha/backend
cpu: AMD EPYC 9V74 80-Core Processor                
                           │    old.txt    │              new.txt               │
                           │    sec/op     │    sec/op     vs base              │
ParseSearchQuery_Simple-4    2.899µ ±  19%   2.491µ ± 40%       ~ (p=0.310 n=6)
ParseSearchQuery_Complex-4   6.934µ ±  25%   7.342µ ± 47%       ~ (p=0.937 n=6)
TokenizeSearchQuery-4        4.751µ ± 112%   3.966µ ± 37%       ~ (p=0.818 n=6)
geomean                      4.571µ          4.170µ        -8.77%

                           │   old.txt   │              new.txt               │
                           │    B/op     │    B/op     vs base                │
ParseSearchQuery_Simple-4    26.00 ± 23%   26.00 ± 0%       ~ (p=1.000 n=6)
ParseSearchQuery_Complex-4   762.0 ±  0%   762.0 ± 0%       ~ (p=1.000 n=6) ¹
TokenizeSearchQuery-4        176.0 ±  0%   176.0 ± 0%       ~ (p=1.000 n=6) ¹
geomean                      151.6         151.6       +0.00%
¹ all samples are equal

                           │  old.txt   │              new.txt               │
                           │ allocs/op  │ allocs/op   vs base                │
ParseSearchQuery_Simple-4    2.000 ± 0%   2.000 ± 0%       ~ (p=1.000 n=6) ¹
ParseSearchQuery_Complex-4   23.00 ± 0%   23.00 ± 0%       ~ (p=1.000 n=6) ¹
TokenizeSearchQuery-4        9.000 ± 0%   9.000 ± 0%       ~ (p=1.000 n=6) ¹
geomean                      7.453        7.453       +0.00%
¹ all samples are equal

pkg: github.com/floatpane/matcha/tui
                    │   old.txt    │               new.txt               │
                    │    sec/op    │    sec/op     vs base               │
LogPanelView-4        160.7µ ± 16%   170.5µ ± 11%        ~ (p=0.240 n=6)
SearchOverlayView-4   183.1µ ± 10%   197.3µ ± 11%        ~ (p=0.180 n=6)
InboxConstruction-4   851.7µ ±  5%   998.7µ ± 18%        ~ (p=0.065 n=6)
geomean               292.6µ         322.7µ        +10.27%

                    │    old.txt     │               new.txt                │
                    │      B/op      │     B/op       vs base               │
LogPanelView-4        21.79Ki ± 105%   44.67Ki ± 51%        ~ (p=0.177 n=6)
SearchOverlayView-4   56.14Ki ±  41%   56.14Ki ± 41%        ~ (p=0.662 n=6)
InboxConstruction-4   874.3Ki ±   0%   874.2Ki ±  0%        ~ (p=0.558 n=6)
geomean               102.3Ki          129.9Ki        +27.04%

                    │   old.txt   │              new.txt              │
                    │  allocs/op  │  allocs/op   vs base              │
LogPanelView-4         712.0 ± 0%    714.0 ± 0%       ~ (p=0.242 n=6)
SearchOverlayView-4    926.0 ± 0%    926.0 ± 0%       ~ (p=1.000 n=6)
InboxConstruction-4   3.478k ± 0%   3.478k ± 0%       ~ (p=0.450 n=6)
geomean               1.319k        1.320k       +0.09%

auto-generated by benchmarks.yml

@andrinoff

Copy link
Copy Markdown
Member Author

/approve

@andrinoff

Copy link
Copy Markdown
Member Author

/build

@floatpanebot floatpanebot left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved on behalf of @andrinoff via /approve command.

@floatpanebot

Copy link
Copy Markdown
Member

Build complete (a1f3382)

Warning

This is an unreviewed PR build and has not been security audited. It may contain bugs, vulnerabilities, or malicious code. Do not use for daily use. Only use for testing purposes.

OS Arch Download
Linux amd64 matcha_preview_linux_amd64.tar.gz
Linux arm64 matcha_preview_linux_arm64.tar.gz
macOS amd64 matcha_preview_darwin_amd64.tar.gz
macOS arm64 matcha_preview_darwin_arm64.tar.gz
Windows amd64 matcha_preview_windows_amd64.zip
Windows arm64 matcha_preview_windows_arm64.zip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/config Configuration / settings area/daemon Daemon / RPC area/fetcher IMAP fetch / IDLE / search area/sender SMTP send path bug Something isn't working size/L Diff: 201–800 lines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

BUG: A bunch of gmail bugs piling up

2 participants