feat: introduction of encoder/hydrator row contract #2536
Merged
Conversation
- rework hash join into spillable bucketed HashTable with configurable join memory via JoinConfig DSL - replace per-adapter RowsNormalizers with shared Row Encoder abstraction (CSV, JSON, XML, Parquet, Doctrine, PostgreSQL, Excel, Seal, Text, Google Sheet) - introduce Row Hydrator (PHP, native, adaptive) with schema-driven entry instantiation and RawRowValues - add NullEntry and NullDefinition for schema-level null handling - rewrite Floe format around stream reader/writer and adaptive PHP/Rust encoders, with matching flow-php-ext hydrate/cast rework - simplify Cache contract and add in-memory buckets cache for sort/group-by
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 1.x #2536 +/- ##
============================================
- Coverage 86.40% 86.31% -0.10%
- Complexity 0 23210 +23210
============================================
Files 1749 1759 +10
Lines 70532 70733 +201
============================================
+ Hits 60944 61054 +110
- Misses 9588 9679 +91
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Log
Added
flow-php/etl- bucketed hash join with disk spilling andJoinConfigDSLflow-php/etl-Row\EncoderandRow\Hydratorabstractions (PHP, native, adaptive)flow-php/etl-NullEntryandNullDefinitionflow-php/etl- Floe stream reader/writer with PHP and Rust encodersflow-php/etl-InMemoryBucketsCachefor external sortflow-php/etl- Serializer DSL functionsflow-php/filesystem- in-memory string source/destination streamsFixed
Changed
flow-php/etl- simplifiedCachecontractflow-php/etl-adapter-csv-RowsNormalizerreplaced withCSVEncoder, schema-driven hydration in extractorflow-php/etl-adapter-doctrine-RowsNormalizerreplaced withDbalEncoder, schema-driven hydration in extractorsflow-php/etl-adapter-excel-ExcelRowsNormalizerreplaced withExcelEncoder, schema-driven hydration in extractorflow-php/etl-adapter-google-sheet-GoogleSheetEncoder, schema-driven hydration in extractorflow-php/etl-adapter-json-RowsNormalizerreplaced withJSONEncoder, schema-driven hydration in extractorsflow-php/etl-adapter-parquet-RowsNormalizerreplaced withParquetEncoder, schema-driven hydration in extractorflow-php/etl-adapter-postgresql-PostgreSqlEncoder, schema-driven hydration in extractorsflow-php/etl-adapter-seal-RowsNormalizerreplaced withSealEncoderflow-php/etl-adapter-text-TextEncoder, schema-driven hydration in extractorflow-php/etl-adapter-xml-RowsNormalizerreplaced withXMLEncoder, schema-driven hydration in extractorsflow-php/flow-php-ext- reworked Rust encode/hydrate/cast pipelineRemoved
flow-php/etl- legacyProcessor\HashJoinhash table and bucketsflow-php/etl-FloeFileand legacy Floe encoders/serializersDeprecated
Security
Since one picture tells more than a thousand words, we pretty much moved away from:
Into
Which allowed us to supercharge some of the expensive operations through rust based php flow dedicated extension flow-php/flow-php-ext 💪
Reworked benchmarks are coming next!
Need help on this PR? Tag
/codesmithwith what you need. Autofix is enabled.