feat(flow-php/etl): schema-driven Floe writes with validation option#2540
Merged
Conversation
- FloeWriter/FloeStreamWriter take schema in constructor, build encoder once - add validateData option to skip per-write schema re-validation - disable validation on external-sort / hash-join spill cache - Options value object plus floe_options() and to_floe(options:) DSL - fast-path identity/count checks in array & metadata equality
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## 1.x #2540 +/- ##
=========================================
Coverage 86.31% 86.31%
- Complexity 23220 23233 +13
=========================================
Files 1760 1761 +1
Lines 70762 70803 +41
=========================================
+ Hits 61080 61117 +37
- Misses 9682 9686 +4 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Log
Added
flow-php/etl- Floe Options value object with validateData toggleflow-php/etl- floe_options() DSL and options argument on to_floe()Fixed
Changed
flow-php/etl- FloeWriter/FloeStreamWriter take schema in constructor and build encoder onceflow-php/etl- external-sort and hash-join spill cache skip per-write schema validationflow-php/etl- fast-path identity and count checks in array and metadata equalityRemoved
Deprecated
Security
Need help on this PR? Tag
/codesmithwith what you need. Autofix is disabled.