Wasm docker upgrade - #2555
Merged
Merged
Conversation
- base image to php:8.5.8-cli-trixie, libpq 18 from PGDG - shared base stage so builder and final image share one apt source - ship flow_php, pgsql and protobuf - document bundled extensions and how to opt out - add .dockerignore
- build PHP 8.5.8 (opcache now mandatory: unistd patch, JIT disabled, HAVE_REALLOCARRAY workaround) - read libpg_query pin from pg-query-ext Makefile so playground and extension share one grammar version - skip pg_query_exit() in MSHUTDOWN so embed SAPI survives engine restarts - add zip extension to Docker image - fix playground examples (database read seeds its own sqlite db, uuid casting) and create output/ dir upfront - refresh codemirror DSL completions and rebuilt php.wasm/flow.phar
- cycle only the request per Run, not the whole PHP module - force Opcache's mmap shared-memory backend on - patch Zend's chunk allocator for Emscripten's whole-mapping-only munmap - restore the ZEND_MM_ERROR allocator diagnostics - recycle the wasm module in the controller as a backstop
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## 1.x #2555 +/- ##
==========================================
Coverage 86.41% 86.41%
- Complexity 23299 23487 +188
==========================================
Files 1800 1800
Lines 71314 71314
==========================================
Hits 61627 61627
Misses 9687 9687 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Log
Added
docker- PHP 8.5 image with libpq 18 and native arrow, flow_php and pg_query extensions enabledwasm- Opcache with a working shared-memory backend in the playgroundwasm- playground recycles the PHP module automatically when memory runs highFixed
wasm- playground no longer leaks memory and stops executing PHP after ~50 runswasm-sortBy()and Floe now work in the playgroundwasm- parquet reads no longer emit integer overflow warnings in the playgroundflow-php/pg-query-ext- no longer frees libpg_query memory on module shutdownChanged
wasm- playground runs PHP 8.5.8 built as 64-bit wasm with libpg_query 18wasm- playground is ~23% faster per runflow-php/arrow-ext- documentation updated for the prebuilt Docker imageRemoved
Deprecated
Security